Remove all keyboard shortcuts #379
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarlef
force-pushed
the
jarlef/remove-all-keyboard-shortcuts
branch
2 times, most recently
from
b5a0899 to
9b8d746
Compare
jarlef
force-pushed
the
jarlef/remove-all-keyboard-shortcuts
branch
from
9b8d746 to
f6add71
Compare
zHaytam
reviewed
Nov 9, 2023
| private readonly Dictionary<string, Func<Diagram, ValueTask>> _shortcuts; | ||
| public record KeyboardShortcut(string Key, bool Ctrl, bool Shift, bool Alt, Func<Diagram, ValueTask> Action); | ||
|
|
||
| private readonly Dictionary<string, KeyboardShortcut> _shortcuts; |
There was a problem hiding this comment.
If we're going to use a record, wouldn't it be better now to just have a list/set of the shortcuts and change the equality check to test for Key+Ctrl+Shift+Alt ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to remove all default registered keyboard shortcuts