Skip to content

Commit

Permalink
stop ignoring tests in newer versions of spring-boot-starter-test
Browse files Browse the repository at this point in the history
Since 2.4 the starter now longer includes junit-vintage-engine
for junit 4 tests so it has to be included explicitly.
  • Loading branch information
david-kubecka authored and beikov committed Jan 9, 2023
1 parent 86e71e5 commit 020ebd7
Show file tree
Hide file tree
Showing 6 changed files with 35 additions and 4 deletions.
6 changes: 6 additions & 0 deletions examples/it-service-management/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,12 @@
<version>${junit-jupiter.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.vintage</groupId>
<artifactId>junit-vintage-engine</artifactId>
<version>${version.junit-vintage}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.h2database</groupId>
<artifactId>h2</artifactId>
Expand Down
10 changes: 8 additions & 2 deletions examples/spring-data-dgs/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,12 @@
<artifactId>junit</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.vintage</groupId>
<artifactId>junit-vintage-engine</artifactId>
<version>${version.junit-vintage}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.h2database</groupId>
<artifactId>h2</artifactId>
Expand Down Expand Up @@ -469,7 +475,7 @@
<properties>
<version.spring>${version.spring-data-2.6-spring}</version.spring>
<version.spring.boot>${version.spring-data-2.6-spring-boot}</version.spring.boot>
<version.hibernate>${version.hibernate-5.4}</version.hibernate>
<version.hibernate>${version.hibernate-5.6}</version.hibernate>
</properties>
<dependencies>
<dependency>
Expand Down Expand Up @@ -498,7 +504,7 @@
</dependency>
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>blaze-persistence-integration-hibernate-5.4</artifactId>
<artifactId>blaze-persistence-integration-hibernate-5.6</artifactId>
</dependency>
</dependencies>
</profile>
Expand Down
10 changes: 8 additions & 2 deletions examples/spring-data-graphql/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,12 @@
<artifactId>junit</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.vintage</groupId>
<artifactId>junit-vintage-engine</artifactId>
<version>${version.junit-vintage}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.h2database</groupId>
<artifactId>h2</artifactId>
Expand Down Expand Up @@ -452,7 +458,7 @@
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>2.12.1</version>
<version>2.13.3</version>
</dependency>
<dependency>
<groupId>${project.groupId}</groupId>
Expand Down Expand Up @@ -521,7 +527,7 @@
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>2.12.1</version>
<version>2.13.3</version>
</dependency>
<dependency>
<groupId>${project.groupId}</groupId>
Expand Down
6 changes: 6 additions & 0 deletions examples/spring-data-spqr/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,12 @@
<artifactId>junit</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.vintage</groupId>
<artifactId>junit-vintage-engine</artifactId>
<version>${version.junit-vintage}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.h2database</groupId>
<artifactId>h2</artifactId>
Expand Down
6 changes: 6 additions & 0 deletions integration/graphql-spqr/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,12 @@
<artifactId>junit</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.vintage</groupId>
<artifactId>junit-vintage-engine</artifactId>
<version>${version.junit-vintage}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.h2database</groupId>
<artifactId>h2</artifactId>
Expand Down
1 change: 1 addition & 0 deletions parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
<version.blazecbav>0.2.0</version.blazecbav>
<version.blazeutils>0.1.21</version.blazeutils>
<version.junit>4.12</version.junit>
<version.junit-vintage>5.9.1</version.junit-vintage>
<version.javassist>3.27.0-GA</version.javassist>
<querydsl.version>5.0.0</querydsl.version>
<!-- 1.18 messed up calculation of load index -->
Expand Down

0 comments on commit 020ebd7

Please sign in to comment.