Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for phi-3-vision-128k-instruct #36

Merged
merged 11 commits into from
Jun 24, 2024
Merged

Add support for phi-3-vision-128k-instruct #36

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4a4823d
phi3_v into mlx_vlm
JosefAlbers Jun 5, 2024
942eeff
Update test_models.py
JosefAlbers Jun 6, 2024
adda5fb
copy pastes of past files into this new rebase
JosefAlbers Jun 23, 2024
45338b1
precommit
JosefAlbers Jun 24, 2024
cc3451e
Merge branch 'main' into rebase-for-phi3v
JosefAlbers Jun 24, 2024
6ea5292
Merge pull request #1 from JosefAlbers/rebase-for-phi3v
JosefAlbers Jun 24, 2024
9f39e1f
precommit
JosefAlbers Jun 24, 2024
20cf225
remove debug print
Blaizzy Jun 24, 2024
20f3143
add prompt format
Blaizzy Jun 24, 2024
91d38b8
add condition to fix quantisation
Blaizzy Jun 24, 2024
4c5048f
bump version
Blaizzy Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove debug print
  • Loading branch information
@Blaizzy
Blaizzy authored Jun 24, 2024
commit 20cf225c61fb24abf02efedcd664a6e8cd50b092
1 change: 0 additions & 1 deletion mlx_vlm/models/phi3_v/vision.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,6 @@ def __call__(
return self.img_processor.vision_model(
img_embeds, output_hidden_states=output_hidden_states
)
# print(0, txt_embeds.shape, img_embeds.shape, img_sizes.shape)
img_embeds = mx.array(img_embeds)
img_sizes = mx.array(img_sizes)
B = img_embeds.shape[0]
Expand Down
Loading