Fix positioned top-k sampling for speculative generation - #2029
Open
tjansn wants to merge 3 commits into
Open
Conversation
Lazarus-931
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
top_kinside_PositionedTargetSampler, before temperature scalingtop_kis non-defaultProblem
Seeded speculative generation already uses a position-keyed target sampler so proposal draws cannot perturb target draws. The selection gate excluded every request with non-default
top_k, however, and the positioned sampler did not apply top-k itself. That sent seeded top-k generation back through the stateful sampler path, where serial and speculative grouping can consume target randomness differently.The server sampling path applies top-k before temperature/top-p sampling. This patch ports that same ordering to the positioned target sampler and removes the now-unnecessary
top_k == 0selection restriction.Validation
temperature=1,top_p=1,top_k=40I could not run the full upstream pytest suite in this environment because pytest is not installed in the pinned runtime.