fix(stt): validate empty Qwen3-ASR audio - #931
Open
ainergiz wants to merge 2 commits into
Open
Conversation
|
Run the following from the repository root, then commit and push any changes: python -m pip install pre-commit
pre-commit run --all-filesThe project's pre-commit configuration includes Black and the other required formatters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #928.
Qwen3-ASR accepts invalid audio, reports mlx-audio's minimum-length padding as valid clip duration, and mishandles the model's
language None<asr_text>no-speech output. This change validates Qwen3-ASR input before inference, preserves the real duration of short clips, and parses language metadata independently for every chunk.Changes
min_chunk_durationpadding.language None<asr_text>as empty language while preserving any returned text.Scope
This does not add an RMS silence threshold because that could reject quiet speech. Silence detection remains the responsibility of the model or VAD.
Validation
git diff --checkpassed.0.01-second segment end.