Onboarding: offline Dia tests + guide updates for quant predicates, KV cache sizing, and batch contracts - #909
Open
mm65x wants to merge 1 commit into
Open
Conversation
…d KV cache sizing
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens the new-model onboarding path based on three failure modes we hit while porting models recently:
fish_qwen3_omniin fix(fish_speech): prevent fast_ path and embeddings from quantizing to fix convert script #905). The adding-a-model guide now documentsmodel_quant_predicatewith examples.diain fix(dia): allocate kv cache to fit prefill + generation length #904). The guide now warns to size caches for prefill + generation combined.Changes
mlx_audio/tts/tests/test_dia.py(new): first offline tests for Dia — tiny random-weight config, no network/downloads; covers config parsing, generation without ref_audio, and the KVCache capacity contract.docs/contributing/adding-a-model.md: new "Prevent Broken Conversions" section (model_quant_predicate), KV cache sizing warning, offline-testing guidance replacing the download-based test example, batch contract note, extended checklist.Companion PRs carrying their own regression tests: #904, #905.