Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsTestDriver does not handle certain unicode characters in tests #1267

Open
thecapdan opened this issue Mar 6, 2015 · 5 comments
Open

jsTestDriver does not handle certain unicode characters in tests #1267

thecapdan opened this issue Mar 6, 2015 · 5 comments
Assignees
Milestone

Comments

@thecapdan
Copy link
Contributor

Trying to test a string that contains Japanese characters. (in most cases, we would use the i18n fixture to test translation tokens, but there may be some valid use cases where we need to test strings that contain these characters)

To reproduce, run the following UT

(function(){
'use strict';
var testCase = {
    setUp : function() {    },
    tearDown : function() { },
    "test JSTs ability to handle unicode" : function()
    { assertEquals('\u30ab', 'カ') }
    ,
    };
TestCase('UnicodeTest', testCase);
}());

Result:

UnicodeTest.test JSTs ability to handle unicode failed (3.00 ms): AssertError: expected "?" but was "?"
      AssertError: expected "?" but was "?"

See discussion at http://code.google.com/p/js-test-driver/issues/detail?id=85 and patch at https://code.google.com/p/js-test-driver/source/detail?r=170a4754abc99c3217d349d55592b86a89000efd

@andyberry88 if you are short of QAs(!) give me a shout and I can add a failing test

@andy-berry-dev
Copy link
Member

@andyberry88 if you are short of QAs(!) give me a shout and I can add a failing test

That would be lovely 😄

@andy-berry-dev andy-berry-dev modified the milestones: 1.0, 1.0 RC1 Mar 6, 2015
@andy-berry-dev andy-berry-dev self-assigned this Mar 12, 2015
andy-berry-dev pushed a commit that referenced this issue Mar 12, 2015
@andy-berry-dev
Copy link
Member

I've added some tests in 3fa7f14 to verify this isn't also an issue in our bundle file creator (which it isn't) so the fix for this is just going to require adding the patch that @thecapdan has linked to above.

@andy-berry-dev andy-berry-dev modified the milestones: Post 1.0, 1.0 RC1 Mar 12, 2015
@andy-berry-dev
Copy link
Member

The plan is to move away from JsTestDriver and support pluggable test runners (#8). Given this is a bug with JsTestDriver I don' think this is something we should look at fixing so I'd suggest we close it. // @dchambers @ioanalianabalas

@ioanalianabalas
Copy link
Contributor

Given that support pluggable test runners are scheduled for the next release after 1.0, I also agree that we can close this.

@dchambers
Copy link
Contributor

I think NPM support will make the likelihood of us ever supporting other test frameworks increasingly less likely. And, in any case, even if we did support another test framework, it seems unreasonable that the test framework that the majority of our tests are currently written in isn't Unicode compatible. Finally, given that this there is a patch for fixing this, unless that patch doesn't work for the version of JsTestDriver we use then I'd like us to re-open this issue and instead fix by applying the patch.

@dchambers dchambers reopened this Jun 3, 2015
@dchambers dchambers modified the milestones: 1.1, Post 1.0 Jun 5, 2015
@dchambers dchambers modified the milestones: Bugs & Docs, 1.1 Sep 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants