-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jsTestDriver does not handle certain unicode characters in tests #1267
Comments
That would be lovely 😄 |
I've added some tests in 3fa7f14 to verify this isn't also an issue in our bundle file creator (which it isn't) so the fix for this is just going to require adding the patch that @thecapdan has linked to above. |
The plan is to move away from JsTestDriver and support pluggable test runners (#8). Given this is a bug with JsTestDriver I don' think this is something we should look at fixing so I'd suggest we close it. // @dchambers @ioanalianabalas |
Given that support pluggable test runners are scheduled for the next release after 1.0, I also agree that we can close this. |
I think NPM support will make the likelihood of us ever supporting other test frameworks increasingly less likely. And, in any case, even if we did support another test framework, it seems unreasonable that the test framework that the majority of our tests are currently written in isn't Unicode compatible. Finally, given that this there is a patch for fixing this, unless that patch doesn't work for the version of JsTestDriver we use then I'd like us to re-open this issue and instead fix by applying the patch. |
Trying to test a string that contains Japanese characters. (in most cases, we would use the i18n fixture to test translation tokens, but there may be some valid use cases where we need to test strings that contain these characters)
To reproduce, run the following UT
Result:
See discussion at http://code.google.com/p/js-test-driver/issues/detail?id=85 and patch at https://code.google.com/p/js-test-driver/source/detail?r=170a4754abc99c3217d349d55592b86a89000efd
@andyberry88 if you are short of QAs(!) give me a shout and I can add a failing test
The text was updated successfully, but these errors were encountered: