fix bug: IllegalStateException of "User defined ID should be populate…

…d before persist" when saving a subtype model with @id fields defined
BlackLabs · Jul 14, 2011 · 98a278b · 98a278b
1 parent 8821e5a
commit 98a278b
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 3 deletions.
diff --git a/README.textile b/README.textile
@@ -1,3 +1,6 @@
+Updates in 1.2.1beta6
+* Fix bug: IllegalStateException of "User defined ID should be populated before persist" when saving a subtype model with @Id fields defined in parent type
+
 Updates in 1.2.1beta5
 * Add disableValidation() to Model. This is useful when your different subtype model have different fields
 * Add @NoId annotation. This help to resolve issue discussed in https://groups.google.com/forum/#!topic/play-framework/hPWJCvefPoI/discussion

diff --git a/documentation/manual/home.textile b/documentation/manual/home.textile
@@ -1,3 +1,6 @@
+Updates in 1.2.1beta6
+* Fix bug: IllegalStateException of "User defined ID should be populated before persist" when saving a subtype model with @Id fields defined in parent type
+
 Updates in 1.2.1beta5
 * Add disableValidation() to Model. This is useful when your different subtype model have different fields
 * Add @NoId annotation. This help to resolve issue discussed in https://groups.google.com/forum/#!topic/play-framework/hPWJCvefPoI/discussion

diff --git a/lib/play-morphia.jar b/lib/play-morphia.jar
diff --git a/src/play/modules/morphia/MorphiaEnhancer.java b/src/play/modules/morphia/MorphiaEnhancer.java
@@ -135,7 +135,7 @@ private void enhance_(CtClass ctClass, ApplicationClass applicationClass, boolea
                 }
                 // setId - for user marked Id entity, setId method needs to be override 
 
-                CtMethod isUserDefinedId = CtMethod.make("protected boolean isUserDefinedId_() {return true;}", ctClass);
+                CtMethod isUserDefinedId = CtMethod.make("protected boolean isUserDefinedId_() {return super.isUserDefinedId_();}", ctClass);
                 ctClass.addMethod(isUserDefinedId);
 
             } else {

diff --git a/src/play/modules/morphia/MorphiaPlugin.java b/src/play/modules/morphia/MorphiaPlugin.java
@@ -49,7 +49,7 @@
  * @author greenlaw110@gmail.com
  */
 public class MorphiaPlugin extends PlayPlugin {
-    public static final String VERSION = "1.2.1beta5";
+    public static final String VERSION = "1.2.1beta6";
 
     private static String msg_(String msg, Object... args) {
         return String.format("MorphiaPlugin-" + VERSION + "> %1$s",
@@ -124,7 +124,7 @@ public void onConfigurationRead() {
             Logger.trace("MongoDB host: %1$s", host);
             Logger.trace("MongoDB port: %1$s", port);
         } catch (UnknownHostException e) {
-            throw new RuntimeException(e.getMessage());
+            throw new RuntimeException("unknown db host: " + e.getMessage());
         }
         String dbName = c.getProperty(PREFIX + "name");
         if (null == dbName) {