Refactoring code base. #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This I'm not entirely sure. If calling will, of course, exit the script then why have a after it?
According to a few webpages, brace expansion in `sh` is not defined (POSIX).
Resources:
http://mywiki.wooledge.org/Bashism
https://github.com/koalaman/shellcheck/wiki/SC2039
Note: although I'm not sure if this will be a problem.
- `local` is undefined by POSIX (http://mywiki.wooledge.org/Bashism) - declaration and assigment should be separated (https://github.com/koalaman/shellcheck/wiki/SC2155) - and using $() rather than `code` (https://github.com/koalaman/shellcheck/wiki/SC2006)
- changing variable uses to a common use inside the script; - adding TODO statement in unfinished functions; - changing `expr` to built-in $(()) ; - using `||` rather than `-o`;
|
thanks a lot for this! |
|
> noptrix commented 8 minutes ago
This is nothing, mate. Just some basic refactoring. No need for a thanks. I'll just ask your patient with English because it's not my native language, I'm from Brazil, so I may write some commit messages wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could have squashed the commits to avoid a big chunk of changes. Although I believe it's easier for the team to see all the changes and even mark a few for a deep review.
This first pull is 100% about refactoring, no new functionality is being added.
I'll work on that in the next weekend or so.
Make sure to read the full commit messages.
I'd love any critics, negative or positive.