Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label argument to createChan API endpoint #2104

Open
wants to merge 1 commit into
base: v0.6
Choose a base branch
from

Conversation

813492291816
Copy link
Contributor

@813492291816 813492291816 commented Nov 7, 2022

jsonrpclib throws errors sometimes due to the auto-generated labels that are based on the passphrases I set. Example:

(-32603, '<class 'api.APIError'>:API Error 0021: Unexpected API Failure - bad interpolation variable reference '%(793569%(4"]'')

This "%(793569%(4"]" is a substring of my label that's based on the passphrase and the error prevents any data from being received.

Because the passphrases I use are generated in a specific way, I can't just exclude certain character combinations as possibilities. Therefore, I propose adding the ability to set the label at the time of the chan creation, which will allow me to set the label to something different/safer than the passphrase.

@PeterSurda
Copy link
Member

I think this should be fixed differently.

@813492291816
Copy link
Contributor Author

I don't know if this is an issue with jsonrpclib or bitmessage, or even how to debug it, but with regard to this PR, I see utility for a number of use cases in allowing the user to set the label of a new chan at creation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants