Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MarshalJSON method #82

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Add MarshalJSON method #82

merged 4 commits into from
Feb 14, 2025

Conversation

shruggr
Copy link
Collaborator

@shruggr shruggr commented Feb 14, 2025

No description provided.

Copy link
Contributor

mergify bot commented Feb 14, 2025

Welcome to our open-source project! 💘

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 5.12821% with 37 lines in your changes missing coverage. Please review.

Project coverage is 35.20%. Comparing base (4d23404) to head (3b7a177).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
b.go 2.85% 34 Missing ⚠️
bob.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #82       +/-   ##
===========================================
- Coverage   50.47%   35.20%   -15.28%     
===========================================
  Files           3        3               
  Lines         105      125       +20     
===========================================
- Hits           53       44        -9     
- Misses         50       80       +30     
+ Partials        2        1        -1     
Flag Coverage Δ
unittests 35.20% <5.12%> (-15.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
bob.go 93.02% <25.00%> (+7.05%) ⬆️
b.go 10.52% <2.85%> (-89.48%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d23404...3b7a177. Read the comment docs.

@rohenaz rohenaz merged commit b37d28d into master Feb 14, 2025
5 of 6 checks passed
@mergify mergify bot deleted the json branch February 14, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants