Payment privacy page minor Lightning iteration #636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Had to resolve a conflict. Would appreciate another review, por favor. |
pavlenex
reviewed
Feb 4, 2022
Contributor
pavlenex
left a comment
pavlenex
left a comment
There was a problem hiding this comment.
Just a minor re-wording. This LGTM, the scope of this page may be expanded later on, if a contributor passionate about privacy decides to dedicate time to it, but this, at least to me, looks like a good high-level overview that should be enough for most designers.
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
pavlenex
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #575.
This is meant as a minimal revision to this page to add Lightning-related privacy information. I am not the best-versed on privacy, so a good review process would be helpful.
We should also clarify the scope of this page. Is it to explain the privacy pitfalls to designers? Or to give specific design recommendations and guidelines. If it's the latter, shouldn't these things already be covered in the send and receive pages that already show full UI mock-ups and flows?
🔒Check out the preview🕵️♀️