Added ⚡️ content to Payments > Sending bitcoin
#589
Conversation
Initial commit with fairly rough content. Still needs a ton of refinement.
GBKS
added
payments
Copy
GBKS
changed the title
Payments > Sending bitcoin
There was a problem hiding this comment.
Nice work and lots of screens which makes me so excited :) I assume that this also touches #580 and does it address all @moneyball's points in #560?
Co-authored-by: bosch <55287964+Bosch-0@users.noreply.github.com>
Co-authored-by: bosch <55287964+Bosch-0@users.noreply.github.com>
Co-authored-by: bosch <55287964+Bosch-0@users.noreply.github.com>
Co-authored-by: bosch <55287964+Bosch-0@users.noreply.github.com>
Co-authored-by: bosch <55287964+Bosch-0@users.noreply.github.com>
Co-authored-by: bosch <55287964+Bosch-0@users.noreply.github.com>
- Added image that shows editing fees - Capitalized payment format examples - Switched gallery to include - Added home screen image to clarify manual payment initiation flow - Rewrite "address" bit and changed to "recipient" - Added "meta data" description
…/github.com/BitcoinDesign/Guide into feature/sending-bitcoin-lightning-iteration
| The need to send bitcoin can be triggered by many different use cases, and initiated by both sender and receiver. Common entry points are: | ||
|
|
||
| You do not need to follow the order below. Feel free to tailor the configuration's order for the payment to what best serves your users. For example, you may make users set the amount before they enter the address. | ||
| - Manual entry of address and amount |
There was a problem hiding this comment.
What's the difference between:
- Manual entry of address and amount and
- Copy & pasting payment information?
There was a problem hiding this comment.
Manual entry is the most basic entry form and has to be supported.
Copy & paste can be an interaction with an input field, but ideally, the app auto-detects clipboard content and presents the appropriate UI automatically.
There was a problem hiding this comment.
Does it have to be supported though? I can't imagine entering it like that and if they did it has major room for error.
pavlenex
left a comment
pavlenex
left a comment
There was a problem hiding this comment.
LGTM for a first, there may be more things we discover as we go forward in 2022. Good work Christoph!
| Sending bitcoin is one of the most essential user activities in a Bitcoin application, and also one of the least structured ones. People may want to send bitcoin to a known contact, transfer it to another wallet on a different device, or make a purchase via a [payment processor]({{ '/guide/getting-started/software/#payment-processors' | relative_url }}). | ||
|
|
||
| Let us look at the main transaction options senders need to configure when moving bitcoin: | ||
| ## Payment entry points |
There was a problem hiding this comment.
Another payment entry point you may want to consider adding is generating and sharing a withdraw request. I'm covering this in my requesting bitcoin page. By withdraw request I'm referring to LNURL-withdraw (withdraw request sounds better imo).
You could expand on this somewhere in this section and discuss how these could be used to generate P2P gift cards.
There was a problem hiding this comment.
I was thinking we could have a "Withdrawing bitcoin" page at a later point.
There was a problem hiding this comment.
Would there be enough content for another dedicated page? Could easily be covered across sending / request page imo
There was a problem hiding this comment.
I don't think it would be enough for a dedicated page. It's def a use-case we should cover, perhaps in a follow up? One more example besides a gift would be a user getting a refund from a merchant so they need to scan a QR in order to pull the funds out.
|
Thanks for the feedback everyone. @pavlenex 100% sure we need to tweak things, especially with the follow-up task to smoothen out bumps between pages once all our current PRs have been merged. |
|
Merging this one, since it's important foundation for the upcoming receive PR and also since it's been ack'd a few times. There are two remaining comments left about LNURL here and manual amount entry here which we agreed may be suitable for smaller follow up PR's after we have a consensus on how we may want to proceed. Great work Christoph and everyone involved, this was a big challenge, let's go! 🚀 |
Initial commit with fairly rough content. Still needs a ton of refinement, so keeping this is a draft for now. So it's not ready for review quite yet, but I am creating the PR so I can get direct feedback on some specific areas.
🚀Preview🧨
The second new page is a sub-page to "Sending bitcoin", and called "Payment request formats". Preview it here.