Tweak Coin Selection page for ⚡️ Lightning #586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 tasks
GBKS
approved these changes
Dec 2, 2021
Contributor
GBKS
left a comment
GBKS
left a comment
There was a problem hiding this comment.
ACK.
I do wonder if we should move this page to the glossary, and later to a "how it works" section once we restructure.
Bosch-0
approved these changes
Dec 3, 2021
Collaborator
Bosch-0
left a comment
Bosch-0
left a comment
There was a problem hiding this comment.
ACK. I agree with @GBKS. This page should be part of our yet-to-be mega case study on savings. I don't think coin-control is something a mobile first, non-custodial, Bitcoin Lightning product should focus on.
It can live in the glossary section for now and we include it in either:
- An advanced features section at the end of the payments page that explores this.
- A mega-savings case study.
Contributor
|
I can make that initial move to the glossary part of my update to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on #573, very minor tweaks.
Preview: https://deploy-preview-586--sad-borg-390916.netlify.app/guide/payments/send/coin-selection/