Skip to content

Added ⚡️ content to Private Key Management > External Signing Devices#555

Merged
GBKS merged 19 commits intoBitcoinDesign:masterfrom
Bosch-0:external_signer
Nov 19, 2021
Merged

Added ⚡️ content to Private Key Management > External Signing Devices#555
GBKS merged 19 commits intoBitcoinDesign:masterfrom
Bosch-0:external_signer

Conversation

@Bosch-0
Copy link
Collaborator

@Bosch-0 Bosch-0 commented Nov 9, 2021

Live preview

Closes #546

  • Added LN content where relevant.
  • Re-framed this page to focus on 'External Signers' as a concept not just hardware wallets. Changed page name to External Signers from External Signing Devices to reflect this.
  • Added image to 'How it works' section.
  • Other minor formatting changes

@Bosch-0 Bosch-0 added this to the Milestone #10 milestone Nov 9, 2021
@Bosch-0 Bosch-0 added Copy Task is about improving text. Design Task is about designing something. How it works Referring to the How it works section. labels Nov 9, 2021
@Bosch-0 Bosch-0 self-assigned this Nov 9, 2021
Copy link
Contributor

@GBKS GBKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update, thank you for tackling this.

One future addition I could see is that of a smart auto-signer based on specific rules (auto-sign low amounts, based on allowances, etc).

For the list of products at the bottom, have there been any changes? Muun, for example, is a 2-of-2 with their service functioning as an auto-signer.

Bosch-0 and others added 3 commits November 11, 2021 20:24
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
@Bosch-0
Copy link
Collaborator Author

Bosch-0 commented Nov 15, 2021

Removed that image in favour of adding a more detailed carousel (#561) showing how this scheme works, thoughts @GBKS?

Copy link
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great page. Will need a bit of work once lighnting signers become the thing.

One thing that was unclear to me is the PSBT part. It isn't my impression that all external signers use PSBT, left comments on relevant places where I'd appreciate clarificaiton.

Besides that just a couple of minor nits. And of course the conflict in image compression that needs to be resolved 😺

Bosch-0 and others added 4 commits November 16, 2021 15:30
Co-authored-by: Pavlenex <pavle@pavle.org>
Co-authored-by: Pavlenex <pavle@pavle.org>
Co-authored-by: Pavlenex <pavle@pavle.org>
Co-authored-by: Pavlenex <pavle@pavle.org>
@Bosch-0 Bosch-0 requested a review from pavlenex November 16, 2021 09:58
pavlenex
pavlenex previously approved these changes Nov 16, 2021
Copy link
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work thanks for addressing the changes quickly 🚀

pavlenex
pavlenex previously approved these changes Nov 16, 2021
@Bosch-0 Bosch-0 requested a review from pavlenex November 17, 2021 09:29
@pavlenex
Copy link
Contributor

@GBKS This PR requires your re-review since it's blocked by request a change 😄

@GBKS
Copy link
Contributor

GBKS commented Nov 18, 2021

All looks good now, thanks for the updates.

I noticed that the Overview page still refers to "External signing device" in the recommendation box, the diagrams, and the image and link under "Personal schemes". Can you address this here, or should we create a new PR for those tweaks?

@Bosch-0
Copy link
Collaborator Author

Bosch-0 commented Nov 18, 2021

Can address is a new PR, will get on to that asap :)

Copy link
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's address the stuff @GBKS mentioned in a different PR.

@pavlenex
Copy link
Contributor

@GBKS Needs your approval to get merged.

Copy link
Contributor

@GBKS GBKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update, especially with the reframing to get away from the device focus.

@GBKS GBKS merged commit 04a035b into BitcoinDesign:master Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Copy Task is about improving text. Design Task is about designing something. How it works Referring to the How it works section.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ⚡️ content to Private key management > External signing device

3 participants