Added ⚡️ content to Private Key Management > External Signing Devices#555
Added ⚡️ content to Private Key Management > External Signing Devices#555GBKS merged 19 commits intoBitcoinDesign:masterfrom
Private Key Management > External Signing Devices#555Conversation
GBKS
left a comment
There was a problem hiding this comment.
Great update, thank you for tackling this.
One future addition I could see is that of a smart auto-signer based on specific rules (auto-sign low amounts, based on allowances, etc).
For the list of products at the bottom, have there been any changes? Muun, for example, is a 2-of-2 with their service functioning as an auto-signer.
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
There was a problem hiding this comment.
Great page. Will need a bit of work once lighnting signers become the thing.
One thing that was unclear to me is the PSBT part. It isn't my impression that all external signers use PSBT, left comments on relevant places where I'd appreciate clarificaiton.
Besides that just a couple of minor nits. And of course the conflict in image compression that needs to be resolved 😺
⚡
Co-authored-by: Pavlenex <pavle@pavle.org>
Co-authored-by: Pavlenex <pavle@pavle.org>
Co-authored-by: Pavlenex <pavle@pavle.org>
Co-authored-by: Pavlenex <pavle@pavle.org>
pavlenex
left a comment
There was a problem hiding this comment.
Great work thanks for addressing the changes quickly 🚀
|
@GBKS This PR requires your re-review since it's blocked by |
|
All looks good now, thanks for the updates. I noticed that the Overview page still refers to "External signing device" in the recommendation box, the diagrams, and the image and link under "Personal schemes". Can you address this here, or should we create a new PR for those tweaks? |
|
Can address is a new PR, will get on to that asap :) |
|
@GBKS Needs your approval to get merged. |
GBKS
left a comment
There was a problem hiding this comment.
Great update, especially with the reframing to get away from the device focus.
⚡ Live preview
Closes #546
External SignersfromExternal Signing Devicesto reflect this.