Skip to content

Added ⚡️ content to Designing Bitcoin Products > Wallet Interoperability#503

Merged
pavlenex merged 29 commits intoBitcoinDesign:masterfrom
Bosch-0:interoperability
Oct 11, 2021
Merged

Added ⚡️ content to Designing Bitcoin Products > Wallet Interoperability#503
pavlenex merged 29 commits intoBitcoinDesign:masterfrom
Bosch-0:interoperability

Conversation

@Bosch-0
Copy link
Collaborator

@Bosch-0 Bosch-0 commented Oct 6, 2021

Added LN and other relevant content to wallet interoperability page (now just interoperability) for #471.

There is a lot of changes here but below are the main ones.

  • Added LN content throughout
  • Renamed page from Wallet interoperability to Interoperability and made content throughout more general / application specific where relevant.
  • Added two new sections: user interface and hardware wallets.
  • Updated a lot of the images to be mobile focused / more clear in what they are depicting.
  • Re-ordered based on my perceived importance / most relevant to the guides primary use case currently.

Live preview

@GBKS GBKS added Copy Task is about improving text. Design bitcoin products Referring to the Design BTC product section. labels Oct 6, 2021
@GBKS GBKS added this to the Milestone #8 milestone Oct 6, 2021
@GBKS GBKS linked an issue Oct 6, 2021 that may be closed by this pull request
6 tasks
@Bosch-0
Copy link
Collaborator Author

Bosch-0 commented Oct 7, 2021

Another suggestion, what do you guys think about adding a section on BIPs and BOLTs here? Adhering to these standards is by definition making things more interoperable. I'll leave it as is for now and open another PR with these additions if people agree.

Copy link
Contributor

@GBKS GBKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good update. Left a few comments. Also make sure to run rake test in order to catch broken links.

Bosch-0 and others added 4 commits October 9, 2021 12:42
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Copy link
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some really awesome suggestions.

I really like what you did with Bolt, LNRURL, suggestions. Glad you included the ability to choose different LSP, this is important.

My only nit-pick is using on-chain vs base layer which is what we used in other chapters preferably.

Bosch-0 and others added 2 commits October 9, 2021 19:48
Co-authored-by: Pavlenex <pavle@pavle.org>
Co-authored-by: Pavlenex <pavle@pavle.org>
@Bosch-0
Copy link
Collaborator Author

Bosch-0 commented Oct 9, 2021

Ty @pavlenex, addressed :)

Copy link
Collaborator

@sbddesign sbddesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Bosch-0 🎉

You and I already discussed technical stuff in the Google doc; I think we cleared that up.

I left several grammatical and stylistic suggestions. While some of these are my opinion in terms of what reads better, there are many about rules of grammar and punctuation.

@sbddesign
Copy link
Collaborator

Another suggestion, what do you guys think about adding a section on BIPs and BOLTs here? Adhering to these standards is by definition making things more interoperable. I'll leave it as is for now and open another PR with these additions if people agree.

That's a good question. Personally, I feel like it might be unneeded overhead. A better approach might be to reference BIPS and BOLTS when necessary (which you already do on the page). For example, "your wallet should support X feature which is defined in BOLT ## blah blah blah..."

Bosch-0 and others added 2 commits October 11, 2021 17:23
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Bosch-0 and others added 8 commits October 11, 2021 17:24
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Copy link
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bosch-0 great work once again. Just two minor suggestions and a question, and this looks ready to go.

Bosch-0 and others added 2 commits October 11, 2021 22:02
Co-authored-by: Pavlenex <pavle@pavle.org>
Co-authored-by: Pavlenex <pavle@pavle.org>
Bosch-0 and others added 2 commits October 12, 2021 00:27
Co-authored-by: Pavlenex <pavle@pavle.org>
Co-authored-by: Daniel Nordh <3393669+danielnordh@users.noreply.github.com>
@pavlenex pavlenex merged commit 66e62e1 into BitcoinDesign:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Copy Task is about improving text. Design bitcoin products Referring to the Design BTC product section.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ⚡️ content to Designing Bitcoin Products > Wallet Interoperability

5 participants