Skip to content

Conversation

@danielnordh
Copy link
Contributor

@danielnordh danielnordh commented Oct 4, 2021

Updates and addition of Lightning content to the relevant sections. From #470

Changes according to this doc: https://docs.google.com/document/d/1Fu-EPdUu9mK3Rsyk_yurWaxUdzGVV1gVD859XMqnQgY/edit?usp=sharing

Preview here: https://deploy-preview-501--sad-borg-390916.netlify.app/guide/designing-products/common-user-flows/

Once any feedback to content changes have been resolved I will re-order a few sections (recover, import wallet comes before securing a wallet etc.)

Copy link
Collaborator

@Bosch-0 Bosch-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, few minor comments left :)

@GBKS GBKS added Copy Task is about improving text. Design bitcoin products Referring to the Design BTC product section. labels Oct 5, 2021
@GBKS GBKS added this to the Milestone #8 milestone Oct 5, 2021
@GBKS
Copy link
Contributor

GBKS commented Oct 5, 2021

LGTM. There are some open comments that I have no strong opinion on, so I will not leave an approval for now.

I think we have to come back to this page later once the onboarding and payments sections are further, and our recommendations around Lightning are more refined. For example, do our recommendations assume that a wallet uses LNURL, keysend and Lightning addresses? If so, then we can describe much smoother payment UX than without those techniques.

Co-authored-by: Christoph Ono <chri@sto.ph>
Copy link
Collaborator

@sbddesign sbddesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good additions.

I left some nit-picky grammar, spelling, and punctuation edits.

Additionally, I raised some discussion points around a few things like elevating the LN content and whether or not an LN wallet can be "switched".

danielnordh and others added 3 commits October 6, 2021 16:16
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
@GBKS GBKS linked an issue Oct 6, 2021 that may be closed by this pull request
6 tasks
Copy link
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd just add that we probably should create a new issue to add Child Pay For Parent (CPFP) in the glossary and link to this page, as RBF isn't the only way to bump a fee, but since CPFP isn't in the glossary, I'll open a new issue to address this and update the page at the same time.

@pavlenex pavlenex merged commit f8a6615 into master Oct 8, 2021
@danielnordh danielnordh deleted the feature/common-user-flows-remaining-lightning-updates branch December 2, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Copy Task is about improving text. Design bitcoin products Referring to the Design BTC product section.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ⚡️ content to Designing Bitcoin Products > Common User flows

6 participants