-
Notifications
You must be signed in to change notification settings - Fork 116
Add ⚡️ content to Common user flows - Remaining sections #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ⚡️ content to Common user flows - Remaining sections #501
Conversation
Bosch-0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, few minor comments left :)
|
LGTM. There are some open comments that I have no strong opinion on, so I will not leave an approval for now. I think we have to come back to this page later once the onboarding and payments sections are further, and our recommendations around Lightning are more refined. For example, do our recommendations assume that a wallet uses LNURL, keysend and Lightning addresses? If so, then we can describe much smoother payment UX than without those techniques. |
Co-authored-by: bosch <55287964+Bosch-0@users.noreply.github.com>
sbddesign
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good additions.
I left some nit-picky grammar, spelling, and punctuation edits.
Additionally, I raised some discussion points around a few things like elevating the LN content and whether or not an LN wallet can be "switched".
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'd just add that we probably should create a new issue to add Child Pay For Parent (CPFP) in the glossary and link to this page, as RBF isn't the only way to bump a fee, but since CPFP isn't in the glossary, I'll open a new issue to address this and update the page at the same time.
Updates and addition of Lightning content to the relevant sections. From #470
Changes according to this doc: https://docs.google.com/document/d/1Fu-EPdUu9mK3Rsyk_yurWaxUdzGVV1gVD859XMqnQgY/edit?usp=sharing
Preview here: https://deploy-preview-501--sad-borg-390916.netlify.app/guide/designing-products/common-user-flows/
Once any feedback to content changes have been resolved I will re-order a few sections (recover, import wallet comes before securing a wallet etc.)