Added ⚡️ content to Designing Bitcoin Products > Principles#494
Merged
pavlenex merged 12 commits intoBitcoinDesign:masterfrom Oct 1, 2021
Merged
Conversation
GBKS
reviewed
Sep 29, 2021
Contributor
GBKS
left a comment
There was a problem hiding this comment.
Looks good, just had some minor recommendations.
| } | ||
|
|
||
| li ul, li ol { | ||
| margin-top: 0; |
Contributor
There was a problem hiding this comment.
Did you validate across the whole site whether this messes up layouts anywhere? If this is meant only for main page content, it should go into _article.scss.
Collaborator
Author
There was a problem hiding this comment.
I did, I scanned every page on the site. The only other place I found a nested list used was on this page and I thought the change looked good there. How do you feel about it?
Co-authored-by: Christoph Ono <chri@sto.ph>
Bosch-0
approved these changes
Oct 1, 2021
Contributor
|
Closes #481 |
46 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⚡️ See Deploy Preview
I have reviewed the Principles page, and I think the principles stand strong. I do not believe that any principles conflict with Lightning, and I do not think any new principles need to be added. I modified some language to include LN and added numerous grammar, style, and typographical fixes.
Criteria
To assess these principles, I took each one and asked myself the following:
Included
The types of wallets that I included in this thought experiment are:
Not Included
The types of wallets that I did not include in this thought experiment
While there are definitely many technical edge cases to consider (and I'm happy to discuss these), I feel like these are edge cases that belong in the realm of engineering and not in principles.
Edits
Self-Custody
Grammar and style fixes
Security
Inclusion
Edited the line about Kenyan farmer. Open to discussion here. It depends on what we mean here. I don't think there is equal access to internet and smartphones everywhere in the world, so I find it to be a problematic claim. Perhaps we just mean in a general sense, like "hypothetically, assuming you have internet and assuming you have a smartphone, nothing prevents you from using Bitcoin?"
Interoperability
Clarified language around wallet import and export for LN. One can't simply export and import a LN wallet in the same manner as an on-chain wallet, but we should absolutely encourage people to make a clear path for the user to move their LN funds to another wallet even if the process looks different than an on-chain backup.
Transparency
Grammar and style fixes.
Privacy
Highlighted LN as a key privacy tool
Decentralization
No edits. This is already fully compatible with LN in my view. A LN node needs access to a Bitcoin node or block filters, so encouraging full nodes or light clients is already LN compatible.