Skip to content

Added ⚡️ content to Designing Bitcoin Products > Usage life cycle#491

Merged
GBKS merged 4 commits intomasterfrom
feature/usage-life-cycle-lightning-revision
Sep 24, 2021
Merged

Added ⚡️ content to Designing Bitcoin Products > Usage life cycle#491
GBKS merged 4 commits intomasterfrom
feature/usage-life-cycle-lightning-revision

Conversation

@GBKS
Copy link
Contributor

@GBKS GBKS commented Sep 21, 2021

Addresses #399.

👶🏻Check the preview🧓🏻

@GBKS GBKS added Copy Task is about improving text. Design bitcoin products Referring to the Design BTC product section. labels Sep 21, 2021
@GBKS GBKS added this to the Milestone #8 milestone Sep 21, 2021
@GBKS GBKS self-assigned this Sep 21, 2021
@GBKS GBKS linked an issue Sep 21, 2021 that may be closed by this pull request
To the personal finance page.
@pavlenex pavlenex self-requested a review September 22, 2021 19:52
@GBKS GBKS marked this pull request as ready for review September 23, 2021 05:49
Copy link
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The only nitpick I have is that

“Is this a convenient way to get done what I want to do?”

sounds odd to me.

@GBKS
Copy link
Contributor Author

GBKS commented Sep 23, 2021

@pavlenex since you approved, I assume that nit is no blocker? The language is def a bit casual, but not a big issue to me. So your call.

@pavlenex
Copy link
Contributor

@pavlenex since you approved, I assume that nit is no blocker? The language is def a bit casual, but not a big issue to me. So your call.

Yup, not a blocker at all, good to go imo.

@GBKS
Copy link
Contributor Author

GBKS commented Sep 24, 2021

@pavlenex thanks for the review, going to merge this now.

@GBKS GBKS merged commit 0adb3cb into master Sep 24, 2021
@danielnordh danielnordh deleted the feature/usage-life-cycle-lightning-revision branch October 4, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Copy Task is about improving text. Design bitcoin products Referring to the Design BTC product section.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ⚡️ content to Designing Bitcoin Products > Usage Life Cycle

2 participants