Skip to content

Conversation

@GBKS
Copy link
Contributor

@GBKS GBKS commented Sep 16, 2021

Added a small paragraph about extensibility to hint at the Lightning network.
Added links to other pages as appropriate.
Revised visual styling of images as they were just black and white before.

As this is a pretty general page about Bitcoin, I don't think it is necessary to add more about Lightning, beyond this one point about extensibility.

🧞‍♂️ Check the preview 🧚‍♀️

Addresses #463.

Added a small paragraph about extensibility to hint at the Lightning network.
Added links to other pages as appropriate.
Revised visual styling of images as they were just black and white before.
@GBKS GBKS added Copy Task is about improving text. Design Task is about designing something. labels Sep 16, 2021
@GBKS GBKS added this to the Milestone #7 milestone Sep 16, 2021
@GBKS GBKS self-assigned this Sep 16, 2021
@GBKS GBKS linked an issue Sep 16, 2021 that may be closed by this pull request
Bosch-0
Bosch-0 previously approved these changes Sep 17, 2021
Copy link
Collaborator

@Bosch-0 Bosch-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Co-authored-by: Daniel Nordh <3393669+danielnordh@users.noreply.github.com>
@pavlenex
Copy link
Contributor

@GBKS you think we can tackle #433 in this one as well?

@GBKS
Copy link
Contributor Author

GBKS commented Sep 20, 2021

@pavlenex good idea, I added a bit about the supply.

@GBKS GBKS linked an issue Sep 20, 2021 that may be closed by this pull request
@GBKS GBKS changed the title Why bitcoin is unique page revision for Lightning and visuals Add ⚡️ content to Getting Started > Why bitcoin is unique Sep 20, 2021
@GBKS GBKS changed the title Add ⚡️ content to Getting Started > Why bitcoin is unique Added ⚡️ content to Getting Started > Why bitcoin is unique Sep 20, 2021
pavlenex
pavlenex previously approved these changes Sep 20, 2021
Copy link
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavlenex
Copy link
Contributor

pavlenex commented Sep 20, 2021

@GBKS Actually the img doesn't load

Screenshot 2021-09-20 at 11 43 05

@pavlenex pavlenex merged commit d25990f into master Sep 20, 2021
@danielnordh danielnordh deleted the feature/why-bitcoin-is-unique-lightning-revision branch October 4, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Copy Task is about improving text. Design Task is about designing something.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ⚡️ content to Getting Started > Why Bitcoin is unique Add information about 21 million cap to the "Why Bitcoin is unique" page

5 participants