Skip to content

Fix for #190 - created artwork for Principles page #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 18, 2021
Merged

Fix for #190 - created artwork for Principles page #453

merged 5 commits into from
Aug 18, 2021

Conversation

sbddesign
Copy link
Collaborator

No description provided.

@sbddesign sbddesign mentioned this pull request Aug 13, 2021
Closed
@sbddesign
Copy link
Collaborator Author

There's some alternate header designs in the Figma file if anyone is interested in seeing:
Figma File

@pavlenex
Copy link
Contributor

Visually, they look great! 😍

Do you think we should re-size them for example like we did here https://deploy-preview-453--sad-borg-390916.netlify.app/guide/designing-products/usage-life-cycle/#unaware ?

johnsBeharry
johnsBeharry reviewed Aug 14, 2021
View reviewed changes
Copy link
Contributor

@johnsBeharry johnsBeharry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbddesign awesome work man, love the style of these icons so much.

@sbddesign
Copy link
Collaborator Author

@pavlenex I made the images inline. It looked a little weird having the images inline with the paragraph text, so I customized it a little bit and made them sit next to the blockquotes.

Bosch-0
Bosch-0 suggested changes Aug 16, 2021
View reviewed changes
Copy link
Collaborator

@Bosch-0 Bosch-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I think the icons look better centered to the block quote. Currently they float slightly above.

image

@GBKS GBKS added the Design Task is about designing something. label Aug 17, 2021
@GBKS GBKS linked an issue Aug 17, 2021 that may be closed by this pull request
Design Visuals for the Principles Section #190
Closed
@pavlenex
Copy link
Contributor

Posting this comment from Christoph

I don't think the formatting with the block quotes next to the images work. How about using bold text instead of block quotes?

Which may solve the alignment problem we're having.

@sbddesign
Copy link
Collaborator Author

The above commit is an attempt to address feedback in this thread as well as in the discussion thread for #190.

pavlenex
pavlenex approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@pavlenex pavlenex merged commit 373a528 into BitcoinDesign:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsBeharry johnsBeharry johnsBeharry left review comments

@Bosch-0 Bosch-0 Bosch-0 requested changes

@pavlenex pavlenex pavlenex approved these changes

Assignees

@sbddesign sbddesign

Labels
Design Task is about designing something.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design Visuals for the Principles Section
5 participants
@sbddesign @pavlenex @johnsBeharry @Bosch-0 @GBKS