Usability and footer tweaks based on feedback#1085
Merged
Conversation
This addresses the super small easy-to-implement site feedback we got from Sven in the Open Source Design forum (https://discourse.opensourcedesign.net/t/new-contribute-join-page-in-the-bitcoin-design-community/3769/2). - Adding Nostr and BitcoinTV logos to the footer - Add a hover tip to the footer logo and the header search icon - Active and visited states for footer links Since Nostr is not a single service, the link goes to Nosta, which is a service meant for showing Nostr profiles. I am also the creator of Nosta, so am I self-serving by doing this? Let me know what you think, we can change the link elsewhere.
✅ Deploy Preview for bitcoin-design-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
GBKS
added
Enhancement
Collaborator
|
LGTM. using Nosta seems perfectly fine. Footer links: I see that when I hover over the link the copy changes from black to orange. Upon click and returning to the page the copy remains black. Was there another hover (visited) state planned or perhaps it is not showing up on my end. |
Collaborator
|
Looks good to me with one exception: I see the active state (orange) in the footer links, but not the visited state (like Mo mentioned as well). Linking to Nosta is fine, I think. |
Turns out browsers don't allow you to use color opacity in visited states.
It's more precise about showing focus styling only when accessibility/keyboard/etc are used, and not during mouse interaction.
Contributor
Author
|
Thanks for the feedback. Can you please check again? I made a few tweaks. |
Collaborator
|
Works perfect! The visited links in the footer are now showing up as grey text, |
mouxdesign
approved these changes
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the super small easy-to-implement site feedback we got from Sven in the Open Source Design forum.
Since Nostr is not a single service, the link goes to Nosta, which is a service meant for showing Nostr profiles. I am also the creator of Nosta, so am I self-serving by doing this? Let me know what you think, we can change the link elsewhere.
Going to keep it as a draft since I want to look over the feedback again and make sure I captured everything that needs to go in this PR.
🩴Check the preview👠