Increase maximum page length to 100, per API #64
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The bitbucket API is often hopelessly slow above 50 results per page, which is why this limit is in place, causing the requests to timeout and need to be retried. Also, not all endpoints support more than 50. :) |
Member
|
The main use cases I envisaged for anyone wanting to customise the per page param, was to lower it, using it with the lazy pager, to keep memory usage down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most page length limits are 100 per page, not 50 as currently hard-coded in
ResultPager.Perhaps a further improvement would be to add a
perPageMax()method toApiInterface, but a basic fix can be implemented without changing API.