make noise pairing confirmation optional over BLE #1468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connecting over Bluetooth requires Bluetooth pairing including pairing code confirmation, so a second noise pairing confirmation is redundant. This does not prevent the host from requesting a pairing code confirmation on demand anyway at any time, it just does not require confirmation on the device to proceed with communicating over noise, when communicting through the BLE chip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connecting over Bluetooth requires Bluetooth pairing including pairing code confirmation, so a second noise pairing confirmation is redundant.
This does not prevent the host from requesting a pairing code confirmation on demand anyway at any time, it just does not require confirmation on the device to proceed with communicating over noise, when communicting through the BLE chip.