Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: run tests in ci in single thread #2686

Conversation

thisconnect
Copy link
Collaborator

@thisconnect thisconnect commented Apr 24, 2024

@thisconnect
Copy link
Collaborator Author

Copy link
Collaborator

@shonsirsha shonsirsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the findings.

I think we could also add this in the vite config instead (if we prefer to have everything vite related 'centralised' in that config file). Anyways, it's fine for me like this.

@thisconnect
Copy link
Collaborator Author

I think we could also add this in the vite config instead (if we prefer to have everything vite related 'centralised' in that config file). Anyways, it's fine for me like this.

Not sure, maybe make webtest locally can use multiple threads or do you prefer if it runs with the same config as in CI?

@shonsirsha
Copy link
Collaborator

I think it's good to actually have it the same as in the CI. @thisconnect

CI sometimes still hangs, trying to run without threads

- vitest-dev/vitest#2008
- vitest-dev/vitest#3077

In earlier vitest versions the optinon was --no-threads, but this
changed to --pool=forks in:
- https://github.com/vitest-dev/vitest/releases/tag/v1.0.0-beta.0
- https://github.com/vitest-dev/vitest/blob/main/docs/guide/migration.md#pools-are-standardized-4172

Changed vitest config, so that CI and make webtest are both using
a single thread.
@thisconnect thisconnect force-pushed the frontend-webtest-ci-in-single-thread branch from 7346e6d to dcf222a Compare April 29, 2024 07:21
@thisconnect thisconnect merged commit ae9b954 into BitBoxSwiss:master Apr 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants