[UC-22] Add Sylius 2.1/2.2 support #25
Conversation
tomkalon
force-pushed
the
UC-22-upgrade-to-sylius-2.1
branch
3 times, most recently
from
2df6d95 to
e5599ea
Compare
tomkalon
force-pushed
the
UC-22-upgrade-to-sylius-2.1
branch
from
e5599ea to
dc32d6f
Compare
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
There was a problem hiding this comment.
It prevents the same action from being performed twice. So if one is active and another commit comes in a moment later, the previous action is canceled. This saves server resources.
.github/workflows/build.yml
Outdated
| sylius: "~2.1.0" | ||
| node: "22.x" | ||
| database: "mysql" | ||
| mysql: "8.4" |
There was a problem hiding this comment.
It is and additional scenario, which is included only for state machine testing purpose. So... You're right. I should use version 8.0.
config/packages/messenger.yaml
Outdated
| # routing: | ||
| # BitBag\SyliusUserComPlugin\Message\OrderSynchronization: user_com_asynchronous | ||
| # BitBag\SyliusUserComPlugin\Message\UserSynchronization: user_com_asynchronous |
There was a problem hiding this comment.
Shouldn't it be removed? Or is this mentioned somewhere in docs to be uncommented if needed? If this needs to be commented out instead of removed, I would put a description comment above.
There was a problem hiding this comment.
🙈 Yes, it should be uncomment. Commented only for dev purpose.
| @@ -0,0 +1,26 @@ | |||
| <?php | |||
|
|
|||
| declare(strict_types=1); | |||
| public function getLogDir(): string | ||
| { | ||
| return $this->getProjectDir() . '/var/log'; | ||
| $kernelClass = str_contains(static::class, "@anonymous\0") ? parent::class : static::class; |
There was a problem hiding this comment.
This logic is too enigmatic... could you put this into some methods, to tell me, what it does?
There was a problem hiding this comment.
It is a standard Kernel for Sylius 2.1:
https://github.com/Sylius/TestApplication/blob/2.1/src/Kernel.php
| imports: | ||
| - { resource: "@SyliusCoreBundle/Resources/config/app/config.yml" } | ||
|
|
||
| - { resource: "@SyliusPayumBundle/Resources/config/app/config.yaml" } |
There was a problem hiding this comment.
How about installing new test-application package?
| autoconfigure: true | ||
|
|
||
| Twig\Extra\Intl\IntlExtension: ~ | ||
| # Twig\Extra\Intl\IntlExtension: ~ |
There was a problem hiding this comment.
No description provided.