Add Behat tests for creating an email template and previewing it #18
Conversation
| @@ -0,0 +1,23 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
|
|
|||
| <!-- | |||
There was a problem hiding this comment.
Do we practise commenting xml files? If so, would you provide it into all xmls? Or if not, maybe better would be to remove the comment?
There was a problem hiding this comment.
I've checked our Bible and there's only
Any *.php file created by the BitBag developer (in Open Source project) needs to have at least the following definition where the author is the user who created this file:
There's no information if we should or should not add this note to other files. When I'm creating a plugin from scratch I have IDE configure to add it whenever it's possible but it would be great to raise this topic on a guild meeting. What do you think?
There was a problem hiding this comment.
I think we can remove the headers for now, we can think about discussion about this on Developers Guild meeting
| xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd" | ||
| > | ||
| <services> | ||
| <defaults public="true" /> |
There was a problem hiding this comment.
When we make some services non-public Behat start to throwing errors. It seems to be an internal requirement coming from behat.
This PR adds Behat tests for: