-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation override fix #406
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ddb1c19
Validation override fix
piotrleo 065cd47
AuthenticationManagerPolyfillPass.php as temp fix for non-existing de…
piotrleo dd7bf4e
Added dependency conflict "doctrine/orm": "^2.10" to prevent 'Unknown…
piotrleo 521efdf
Moved AuthenticationManagerPolyfillPass from test env to dev/prod
piotrleo 481fe27
Removed unused import
piotrleo 97a913e
AuthenticationManagerPolyfillPass is still needed in test env, revert…
piotrleo 7b138a0
Added dev dependency polishsymfonycommunity/symfony-mocker-container
piotrleo 6494cf3
Updated node for GHA
piotrleo a428cf5
Added "yarn add gulp"
piotrleo e7dba0f
Revert "Added "yarn add gulp""
piotrleo a6d35b1
Removed gulp build
piotrleo b647dff
Merge branch 'master' into validation_override_fix
piotrleo ceb7e72
Added yarn encore dev
piotrleo 8a35cf1
Fixed one behat test with slug fill
piotrleo b6b38cb
Reverted behat.yml.dist changes
piotrleo 5639a42
Removed AuthenticationPolyfillPass from test app Kernel
piotrleo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
AuthenticationManagerPolyfillPass.php as temp fix for non-existing de…
…pendency: security.authentication_manager
- Loading branch information
commit 065cd47d6eaa059a80e342c532695eaeadd2e874
There are no files selected for viewing
20 changes: 20 additions & 0 deletions
20
src/DependencyInjection/Compiler/AuthenticationManagerPolyfillPass.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
<?php | ||
|
||
namespace BitBag\SyliusCmsPlugin\DependencyInjection\Compiler; | ||
|
||
use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface; | ||
use Symfony\Component\DependencyInjection\ContainerBuilder; | ||
|
||
class AuthenticationManagerPolyfillPass implements CompilerPassInterface | ||
{ | ||
public function process(ContainerBuilder $container): void | ||
{ | ||
if ( | ||
$container->has('security.authentication_manager') === false | ||
&& | ||
$container->has('security.authentication.manager') === true | ||
) { | ||
$container->setAlias('security.authentication_manager', 'security.authentication.manager'); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be present in Plugin class in src. Currently, it's limited to test application, IMO it should be attached wherever needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done