Added RINT function to V2 engine #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## integ-rint #240 +/- ##
=============================================
Coverage 98.38% 98.38%
- Complexity 3695 3698 +3
=============================================
Files 343 343
Lines 9113 9118 +5
Branches 582 582
=============================================
+ Hits 8966 8971 +5
Misses 142 142
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
acarbonetto
approved these changes
Mar 7, 2023
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunction.java
Show resolved
Hide resolved
integ-test/src/test/java/org/opensearch/sql/sql/MathematicalFunctionIT.java
Outdated
Show resolved
Hide resolved
GumpacG
approved these changes
Mar 8, 2023
Yury-Fridlyand
approved these changes
Mar 8, 2023
...src/test/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunctionTest.java
Outdated
Show resolved
Hide resolved
matthewryanwells
changed the title
Xcontent classes were moved in this PR opensearch-project/OpenSearch#5902 causing builds to fail. --------- Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> Signed-off-by: Matthew Wells <matthew.wells@improving.com>
…search-project#1387) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Matthew Wells <matthew.wells@improving.com>
…/Integration tests Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
…pensearch-project#1389) (opensearch-project#1396) * Refactor AWSSigV4 auth to support different AWSCredentialProviders Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Added unit tests for sts assume role credentials provider Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit 8583fd1) Co-authored-by: vamsi-amazon <reddyvam@amazon.com> Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
…rface (opensearch-project#1408) * Added DataSourceMetadataStorage interface Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Added new interface methods in DataSourceService and DataSourceMetadataStorage Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Peng Huo <penghuo@gmail.com> Signed-off-by: Matthew Wells <matthew.wells@improving.com>
matthewryanwells
force-pushed
the
dev-rint
branch
from
4bea29b to
55653d8
Compare
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
GabeFernandez310
approved these changes
Mar 13, 2023
matthewryanwells
added a commit
that referenced
this pull request
Mar 15, 2023
Added RINT to V2 engine, updated documentation, added unit and IT tests Signed-off-by: Matthew Wells <matthew.wells@improving.com>
GabeFernandez310
pushed a commit
that referenced
this pull request
Mar 16, 2023
…ensearch-project#1439) Added RINT to V2 engine, updated documentation, added unit and IT tests Signed-off-by: Matthew Wells <matthew.wells@improving.com> (cherry picked from commit 7220cfe) Co-authored-by: Matthew Wells <matthew.wells@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added math function RINT to V2 engine, updated documentation, and added unit/IT tests. Additionally fixed small typo in the EXPM1 description
Issues Resolved
opensearch-project#1190
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.