Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified returning NaN to NULL #225

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Modified returning NaN to NULL #225

merged 2 commits into from
Feb 15, 2023

Conversation

GumpacG
Copy link

@GumpacG GumpacG commented Feb 13, 2023

Signed-off-by: Guian Gumpac guian.gumpac@improving.com

Description

Modified ln, log, log10, and log2 functions to return null when the Math functions return NaN.

Issues Resolved

opensearch-project#1280

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@GumpacG GumpacG requested a review from a team February 13, 2023 19:30
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #225 (5be477e) into integ-fix-nan-bug (e990201) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@                 Coverage Diff                  @@
##             integ-fix-nan-bug     #225   +/-   ##
====================================================
  Coverage                98.36%   98.36%           
- Complexity                3636     3642    +6     
====================================================
  Files                      343      343           
  Lines                     8990     8995    +5     
  Branches                   585      585           
====================================================
+ Hits                      8843     8848    +5     
  Misses                     142      142           
  Partials                     5        5           
Flag Coverage Δ
sql-engine 98.36% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ssion/operator/arthmetic/MathematicalFunction.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
@GumpacG GumpacG merged commit 7108a75 into integ-fix-nan-bug Feb 15, 2023
GabeFernandez310 pushed a commit that referenced this pull request Feb 15, 2023
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants