[JDBC] Change default Precison and DisplaySize for all datetime types.
#185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
Yury-Fridlyand
requested review from
kylepbit,
GumpacG,
forestmvey,
GabeFernandez310,
MaxKsyunz,
acarbonetto,
MitchellGale and
margarit-h
Codecov Report
@@ Coverage Diff @@
## integ-fix-#923 opensearch-project/sql#185 +/- ##
====================================================
- Coverage 98.30% 95.80% -2.51%
Complexity 3518 3518
====================================================
Files 342 352 +10
Lines 8694 9352 +658
Branches 554 673 +119
====================================================
+ Hits 8547 8960 +413
- Misses 142 334 +192
- Partials 5 58 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
margarit-h
approved these changes
Dec 9, 2022
acarbonetto
approved these changes
Dec 9, 2022
forestmvey
approved these changes
Dec 9, 2022
Yury-Fridlyand
changed the title
Precison and DisplaySize for TIME and DATE types.JDBC] Change default Precison and DisplaySize for TIME and DATE types.
|
I just had a general question. What unit of measurement are |
GabeFernandez310
approved these changes
Dec 9, 2022
According to docs:
|
acarbonetto
reviewed
Dec 13, 2022
| DATE(JDBCType.DATE, Date.class, 24, 24, false), | ||
| TIME(JDBCType.TIME, Time.class, 24, 24, false), | ||
| DATE(JDBCType.DATE, Date.class, 10, 10, false), | ||
| TIME(JDBCType.TIME, Time.class, 8, 8, false), | ||
| DATETIME(JDBCType.TIMESTAMP, Timestamp.class, 24, 24, false), | ||
| TIMESTAMP(JDBCType.TIMESTAMP, Timestamp.class, 24, 24, false), |
There was a problem hiding this comment.
Should we update DATETIME and TIMESTAMP to a precision of 9?
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
6 tasks
Yury-Fridlyand
changed the title
JDBC] Change default Precison and DisplaySize for TIME and DATE types.JDBC] Change default Precison and DisplaySize for all datetime types.
MitchellGale
approved these changes
Dec 14, 2022
MaxKsyunz
approved these changes
Dec 14, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yury-Fridlyand yuryf@bitquilltech.com
Description
The proposed fix changes default
PrecisionandDisplaySizeconfigured forTIMEandDATEtypes.opensearch-project-sql/sql-jdbc/src/main/java/org/opensearch/jdbc/types/OpenSearchType.java
Lines 146 to 147 in 522901d
Precisionis the third arg andDisplaySizeis the fourth arg.opensearch-project-sql/sql-jdbc/src/main/java/org/opensearch/jdbc/types/OpenSearchType.java
Lines 65 to 66 in 522901d
Please, note, classes referenced here
^arejava.sql.*classes, notjava.time.*ones.Timehas no fraction seconds part.Test
Before
After
Issues Resolved
opensearch-project/sql-jdbc#21
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.