Add position() to V2 engine #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
Codecov Report
@@ Coverage Diff @@
## integ-add-position-to-v2 #177 +/- ##
==============================================================
- Coverage 98.29% 95.79% -2.51%
- Complexity 3465 3470 +5
==============================================================
Files 347 357 +10
Lines 8645 9314 +669
Branches 550 669 +119
==============================================================
+ Hits 8498 8922 +424
- Misses 142 334 +192
- Partials 5 58 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
core/src/main/java/org/opensearch/sql/expression/text/TextFunction.java
Outdated
Show resolved
Hide resolved
|
|
||
| /** | ||
| * POSITION(substr IN str) returns the position of the first occurrence of a substring in a string. | ||
| * If the substring is not found within the original string, this function returns 0. |
There was a problem hiding this comment.
Maybe: reference LOCATE function and signature (see other functions' docs).
Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
Yury-Fridlyand
approved these changes
Nov 25, 2022
Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
margarit-h
changed the title
GumpacG
reviewed
Nov 28, 2022
GumpacG
approved these changes
Nov 28, 2022
Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
acarbonetto
requested changes
Nov 28, 2022
core/src/main/java/org/opensearch/sql/analysis/ExpressionAnalyzer.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| public UnresolvedExpression position(UnresolvedExpression left, UnresolvedExpression right) { | ||
| return new PositionFunction(left, right); |
There was a problem hiding this comment.
Same comment as above: can we used a better description than left and right?
core/src/main/java/org/opensearch/sql/ast/expression/PositionFunction.java
Outdated
Show resolved
Hide resolved
| @ToString | ||
| public class PositionFunction extends UnresolvedExpression { | ||
| @Getter | ||
| private UnresolvedExpression left; |
There was a problem hiding this comment.
Same comment as above:
Can we used a better description than left and right?
core/src/main/java/org/opensearch/sql/expression/function/BuiltinFunctionName.java
Show resolved
Hide resolved
core/src/test/java/org/opensearch/sql/expression/text/TextFunctionTest.java
Show resolved
Hide resolved
| void position() { | ||
| FunctionExpression expression = DSL.position( | ||
| DSL.literal("world"), | ||
| DSL.literal("helloworld")); |
There was a problem hiding this comment.
can you change this to "helloworldworld"? Then it will also cover the duplicate case.
sql/src/test/java/org/opensearch/sql/sql/parser/AstExpressionBuilderTest.java
Show resolved
Hide resolved
forestmvey
reviewed
Nov 28, 2022
| assertEquals(INTEGER, expression.type()); | ||
| assertEquals(6, eval(expression).integerValue()); | ||
|
|
||
| when(nullRef.type()).thenReturn(STRING); |
There was a problem hiding this comment.
Can we split these out into null and missing tests.
forestmvey
approved these changes
Nov 28, 2022
Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
acarbonetto
approved these changes
Nov 30, 2022
core/src/test/java/org/opensearch/sql/analysis/NamedExpressionAnalyzerTest.java
Show resolved
Hide resolved
margarit-h
added a commit
that referenced
this pull request
Nov 30, 2022
Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
margarit-h
added a commit
that referenced
this pull request
Dec 5, 2022
Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com> Rebased
margarit-h
added a commit
that referenced
this pull request
Dec 5, 2022
Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com> Rbased
margarit-h
added a commit
that referenced
this pull request
Dec 5, 2022
Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com> Rbased
margarit-h
added a commit
that referenced
this pull request
Dec 6, 2022
This reverts commit eee57aa.
margarit-h
added a commit
that referenced
this pull request
Dec 6, 2022
Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com> Rbased
margarit-h
added a commit
that referenced
this pull request
Dec 6, 2022
This reverts commit eee57aa.
margarit-h
added a commit
that referenced
this pull request
Dec 6, 2022
Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com> Rebased Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
margarit-h
added a commit
that referenced
this pull request
Dec 6, 2022
Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com> Rbased Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
margarit-h
added a commit
that referenced
this pull request
Dec 6, 2022
This reverts commit eee57aa. Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
andy-k-improving
pushed a commit
that referenced
this pull request
Nov 16, 2024
Optional is not required since api returns list instead of object. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Margarit Hakobyan margarith@bitquilltech.com
Description
Usage: The syntax POSITION(substr IN str) returns the position of the first occurrence of substring substr in string str. Returns 0 if substr is not in str. Returns NULL if any argument is NULL.
Argument type: STRING, STRING, INTEGER
Return type integer:
(STRING IN STRING) -> INTEGER
Example::
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.