Skip to content

apacheGH-30622: [GAC-47] Move Timestream ODBC driver seed under cpp/src/flightsql_odbc #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2023
Merged

apacheGH-30622: [GAC-47] Move Timestream ODBC driver seed under cpp/src/flightsql_odbc #8

merged 1 commit into from
Dec 7, 2023

Conversation

@alinaliBQ
Copy link

Rationale for this change

What changes are included in this PR?

Move Timestream ODBC driver seed under cpp/src/flightsql_odbc

Are these changes tested?

N/A, since code is just moved. Updated workflows to accommodate this change.

Are there any user-facing changes?

No.

@alinaliBQ
Move Timestream ODBC driver seed under cpp/src/flightsql_odbc
400a6b4 
* Updated workflows to accommodate this change.
@github-actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

Windows 2022 (x32) Build Unit Test Results

  1 files  ±0    1 suites  ±0   1s ⏱️ ±0s
74 tests ±0  73 ✔️ ±0  1 💤 ±0  0 ❌ ±0 
73 runs  ±0  72 ✔️ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 400a6b4. ± Comparison against base commit a8fa31e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

Windows 2022 (x32) Build Integration Test Results

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 400a6b4. ± Comparison against base commit a8fa31e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

Ubuntu 20.04 Debug Build Unit Test Results

  1 files  ±0    1 suites  ±0   1s ⏱️ ±0s
73 tests ±0  72 ✔️ ±0  1 💤 ±0  0 ❌ ±0 
72 runs  ±0  72 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 400a6b4. ± Comparison against base commit a8fa31e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

Ubuntu 20.04 Debug Build Integration Test Results

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 400a6b4. ± Comparison against base commit a8fa31e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 6, 2023 •
edited
Loading

Ubuntu 20.04 Build Unit Test Results

  1 files  ±0    1 suites  ±0   0s ⏱️ ±0s
73 tests ±0  72 ✔️ ±0  1 💤 ±0  0 ❌ ±0 
72 runs  ±0  72 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 400a6b4. ± Comparison against base commit a8fa31e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 6, 2023 •
edited
Loading

Ubuntu 20.04 Build Integration Test Results

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 400a6b4. ± Comparison against base commit a8fa31e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 6, 2023 •
edited
Loading

Windows 2022 (x64) Build Unit Test Results

  1 files  ±0    1 suites  ±0   1s ⏱️ -1s
74 tests ±0  73 ✔️ ±0  1 💤 ±0  0 ❌ ±0 
73 runs  ±0  72 ✔️ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 400a6b4. ± Comparison against base commit a8fa31e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 6, 2023 •
edited
Loading

Windows 2022 (x64) Build Integration Test Results

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 400a6b4. ± Comparison against base commit a8fa31e.

♻️ This comment has been updated with latest results.

@alinaliBQ alinaliBQ marked this pull request as ready for review December 6, 2023 00:13
@github-actions
Copy link

github-actions bot commented Dec 6, 2023

Ubuntu 20.04 Debug Build Test Results Check

Code Coverage

Package Line Rate Branch Rate Complexity Health
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.core 26% 0% 0 ❌
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.core.auth 100% 67% 0 ✔
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.core.client 20% 38% 0 ❌
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.core.config 67% 0% 0 ➖
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.core.endpoint 0% 0% 0 ❌
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.core.http 100% 0% 0 ✔
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.core.utils 100% 50% 0 ✔
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.core.utils.json 100% 0% 0 ✔
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.core.utils.memory 67% 38% 0 ➖
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.core.utils.memory.stl 100% 50% 0 ✔
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.crt 45% 25% 0 ❌
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.crt.endpoints 0% 0% 0 ❌
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.sts 7% 0% 0 ❌
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.sts.model 100% 0% 0 ✔
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.timestream-query 11% 0% 0 ❌
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.timestream-query.model 48% 0% 0 ❌
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.include.ignite.common.include.common 0% 0% 0 ❌
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.include.ignite.odbc 100% 0% 0 ✔
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.include.ignite.odbc.config 67% 0% 0 ➖
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.include.ignite.odbc.diagnostic 100% 0% 0 ✔
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.include.timestream.odbc 24% 5% 0 ❌
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.include.timestream.odbc.app 38% 0% 0 ❌
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.include.timestream.odbc.authentication 100% 50% 0 ✔
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.include.timestream.odbc.config 0% 0% 0 ❌
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.include.timestream.odbc.diagnostic 56% 50% 0 ➖
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.include.timestream.odbc.meta 18% 9% 0 ❌
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.include.timestream.odbc.query 85% 50% 0 ✔
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.os.ignite.common.os.linux.src.common 24% 42% 0 ❌
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.src 20% 8% 0 ❌
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.src.app 7% 6% 0 ❌
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.src.authentication 93% 48% 0 ✔
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.src.config 64% 34% 0 ➖
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.src.diagnostic 23% 11% 0 ❌
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.src.ignite.common.src 0% 0% 0 ❌
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.src.ignite.common.src.common 0% 0% 0 ❌
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.src.meta 51% 16% 0 ➖
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.src.query 9% 6% 0 ❌
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.tests.integration-test.include 0% 0% 0 ❌
cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.tests.integration-test.src 0% 0% 0 ❌
Summary 14% (2326 / 17109) 5% (4449 / 98275) 0 ❌

@github-actions
Copy link

github-actions bot commented Dec 6, 2023 •
edited
Loading

MacOS Big Sur 11 Build Unit Test Results

  1 files    1 suites   8s ⏱️
73 tests 72 ✔️ 1 💤 0 ❌
72 runs  71 ✔️ 1 💤 0 ❌

Results for commit c14df61c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 6, 2023 •
edited
Loading

MacOS Big Sur 11 Build Integration Test Results

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit c14df61c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 6, 2023 •
edited
Loading

MacOS Big Sur 11 Debug Build Unit Test Results

  1 files    1 suites   8s ⏱️
73 tests 72 ✔️ 1 💤 0 ❌
72 runs  71 ✔️ 1 💤 0 ❌

Results for commit c14df61c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 6, 2023 •
edited
Loading

MacOS Big Sur 11 Debug Build Integration Test Results

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit c14df61c.

♻️ This comment has been updated with latest results.

@affonsov
Copy link

affonsov commented Dec 6, 2023

Is the folder structure correct arrow\cpp\src\flightsql_odbc\amazon-timestream-odbc-driver?

@alinaliBQ
Copy link
Author

alinaliBQ commented Dec 6, 2023 •
edited
Loading

Is the folder structure correct arrow\cpp\src\flightsql_odbc\amazon-timestream-odbc-driver?

@affonsov Yes, I put it like that so later we could add arrow\cpp\src\flightsql_odbc\flightsql-odbc-dremio. The end goal is that arrow\cpp\src\flightsql_odbc would be the root. For now we'll just keep timestream and dremio flight sql code separate.

@github-actions
Copy link

github-actions bot commented Dec 6, 2023

Windows 2022 (x64) Debug Build Code Coverage Test Results Check

Code Coverage

Package Line Rate Branch Rate Complexity Health
D:\a\arrow\arrow\cpp\src\flightsql_odbc\amazon-timestream-odbc-driver\build\odbc\bin\Debug\timestream-odbc-unit-tests.exe 27% 0% 0 ❌
Summary 27% (2367 / 8643) 0% (0 / 0) 0 ❌

@github-actions
Copy link

github-actions bot commented Dec 6, 2023

MacOS Big Sur 11 Debug Build Code Coverage Unit and Integration Test Result

Code Coverage

Package Line Rate Branch Rate Complexity Health
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.core 100% 50% 0 ✔
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.core.auth 100% 83% 0 ✔
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.core.client 54% 50% 0 ➖
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.core.config 67% 0% 0 ➖
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.core.endpoint 0% 0% 0 ❌
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.core.http 100% 0% 0 ✔
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.core.utils 100% 50% 0 ✔
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.core.utils.json 100% 0% 0 ✔
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.core.utils.memory 60% 38% 0 ➖
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.core.utils.memory.stl 100% 0% 0 ✔
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.core.utils.threading 0% 0% 0 ❌
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.crt 100% 100% 0 ✔
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.crt.endpoints 0% 0% 0 ❌
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.sts 14% 0% 0 ❌
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.sts.model 100% 0% 0 ✔
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.timestream-query 100% 0% 0 ✔
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.aws-sdk-cpp.install.include.aws.timestream-query.model 50% 38% 0 ➖
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.include.ignite.common.include.common 2% 1% 0 ❌
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.include.ignite.odbc 100% 0% 0 ✔
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.include.ignite.odbc.config 100% 0% 0 ✔
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.include.ignite.odbc.diagnostic 100% 0% 0 ✔
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.include.timestream.odbc 23% 6% 0 ❌
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.include.timestream.odbc.app 38% 0% 0 ❌
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.include.timestream.odbc.authentication 100% 50% 0 ✔
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.include.timestream.odbc.config 100% 50% 0 ✔
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.include.timestream.odbc.diagnostic 60% 50% 0 ➖
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.include.timestream.odbc.meta 25% 9% 0 ❌
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.include.timestream.odbc.query 85% 0% 0 ✔
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.os.ignite.common.os.linux.src.common 25% 35% 0 ❌
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.src 20% 8% 0 ❌
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.src.app 9% 3% 0 ❌
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.src.authentication 96% 49% 0 ✔
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.src.config 63% 33% 0 ➖
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.src.diagnostic 40% 13% 0 ❌
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.src.ignite.common.src 0% 0% 0 ❌
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.src.ignite.common.src.common 0% 0% 0 ❌
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.src.meta 51% 14% 0 ➖
arrow.cpp.src.flightsql_odbc.amazon-timestream-odbc-driver.src.odbc.src.query 12% 7% 0 ❌
Summary 25% (2698 / 10807) 10% (4813 / 50040) 0 ❌

@alinaliBQ alinaliBQ merged this pull request into GAC-odbc-driver Dec 7, 2023
alinaliBQ pushed a commit that referenced this pull request Dec 7, 2023
@forestmvey @alinaliBQ
Fixing awslabs links. (#8)
8409561 
Signed-off-by: forestmvey <forestv@bitquilltech.com>
@alinaliBQ alinaliBQ deleted the alinaliBQ/GAC-47/move-ts-driver branch December 7, 2023 22:17
alinaliBQ pushed a commit that referenced this pull request Dec 13, 2023
@forestmvey @alinaliBQ
Fixing awslabs links. (#8)
5ef7275 
Signed-off-by: forestmvey <forestv@bitquilltech.com>
alinaliBQ pushed a commit that referenced this pull request Dec 18, 2023
@forestmvey @alinaliBQ
Fixing awslabs links. (#8)
9270760 
Signed-off-by: forestmvey <forestv@bitquilltech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@affonsov affonsov affonsov approved these changes

Assignees

No one assigned

Labels

awaiting committer review Component: C++ Component: Documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alinaliBQ @affonsov