Use arrow::flight::sql::odbc namespace #110
Open
+1,396
−1,888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinaliBQ
reviewed
Sep 26, 2025
alinaliBQ
reviewed
Sep 26, 2025
| namespace driver { | ||
| namespace flight_sql { | ||
| namespace arrow::flight::sql::odbc { | ||
| namespace utils { |
There was a problem hiding this comment.
I am okay with this change. Just a clarification:
I think I saw something else at standup when I thought Arrow used utils in existing code. I had realized that Arrow currently doesn't have any utils namespace in C++ code. Arrow does use utils namespace from other places, such as Aws::Utils:: etc. Arrow also has classes like CopyDataUtils but that's not a namespace either. Hopefully the community is good with this approach
There was a problem hiding this comment.
Nvm, I see Arrow does have Arrow::util namespace. 🤦♀️
Should we use util instead of utils to be consistent?
cpp/src/arrow/flight/sql/odbc/flight_sql/flight_sql_connection.cc
Outdated
Show resolved
Hide resolved
cpp/src/arrow/flight/sql/odbc/flight_sql/flight_sql_statement.cc
Outdated
Show resolved
Hide resolved
cpp/src/arrow/flight/sql/odbc/flight_sql/flight_sql_statement_get_columns.cc
Outdated
Show resolved
Hide resolved
cpp/src/arrow/flight/sql/odbc/flight_sql/accessors/date_array_accessor_test.cc
Show resolved
Hide resolved
cpp/src/arrow/flight/sql/odbc/odbcabstraction/odbc_impl/odbc_environment.cc
Show resolved
Hide resolved
justing-bq
force-pushed
the
fixNamespace
branch
from
10518a0 to
c77a844
Compare
Update namespaces driver::flight_sql and driver::odbcabstraction to arrow::flight::sql::odbc.
justing-bq
force-pushed
the
fixNamespace
branch
from
c77a844 to
d90733a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We want our ODBC code to live in the
arrow::flight::sql::odbcnamespace.What changes are included in this PR?
The two utils.cc/h files have been combined into one utils.cc/h and all that logic is put inside a new
utilsnamespace insidearrow::flight::sql::odbc. Thedriver::flight_sqlanddriver::odbcabstractionnamespaces have both been replaced witharrow::flight::sql::odbc.Are these changes tested?
N/A
Are there any user-facing changes?
No