feat: re-authorization for google sheet feature added. #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontend-dev/src/components/AllIntegrations/GoogleSheet/EditGoogleSheet.jsx
Show resolved
Hide resolved
| sheetConf={sheetConf} | ||
| setSheetConf={setSheetConf} | ||
| step={step} | ||
| setstep={setStep} |
frontend-dev/src/components/AllIntegrations/GoogleSheet/EditGoogleSheet.jsx
Outdated
Show resolved
Hide resolved
Comment on lines
45
to
48
| if (authData.length === 1 && !isInfo && !isEdit) { | ||
| setSelectedUserId(authData[0].id); | ||
| } else if (!selectedUserId && authData.length > 0 && !isInfo && !isEdit) { | ||
| setSelectedUserId(authData[authData.length - 1].id); |
There was a problem hiding this comment.
separate !isInfo && !isEdit from this conditions
frontend-dev/src/components/OneClickRadioComponents/AuthorizationAccountList.jsx
Outdated
Show resolved
Hide resolved
frontend-dev/src/components/AllIntegrations/GoogleSheet/GoogleSheetAuthorization.jsx
Outdated
Show resolved
Hide resolved
frontend-dev/src/components/AllIntegrations/GoogleSheet/GoogleSheetAuthorization.jsx
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
| } | ||
| }, [authData]) |
There was a problem hiding this comment.
add other necessary dependencies here
frontend-dev/src/components/AllIntegrations/GoogleSheet/GoogleSheetAuthorization.jsx
Outdated
Show resolved
Hide resolved
|
|
||
| if (step === 1 && isEdit) { | ||
|
|
||
| const updatedConf = { ...sheetConf } |
There was a problem hiding this comment.
unnecessary spread operation,
Spreading an object creates a shallow copy of that object, which allows you to modify the copy without affecting the original object. This is important when you want to follow immutability principles. In immutability, instead of changing an object's properties directly, you create a new object with the modified values.
shuvomohajan
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.