Feat/fabman-action #116

Md-Abed-Hossen · 2025-09-08T09:39:32Z

No description provided.

This reverts commit e4b0bfc.

frontend-dev/src/components/AllIntegrations/Fabman/EditFabman.jsx

frontend-dev/src/components/AllIntegrations/Fabman/Fabman.jsx

frontend-dev/src/components/AllIntegrations/Fabman/IntegrationHelpers.jsx

includes/Actions/Fabman/FabmanController.php

includes/Actions/Fabman/RecordApiHelper.php

Copilot

Pull Request Overview

This PR adds a new Fabman integration to the system, enabling users to manage members and spaces through the Fabman API.

Introduces comprehensive Fabman API integration with authentication, workspace management, and CRUD operations for members and spaces
Adds complete frontend UI components for configuration, field mapping, and workflow management
Implements backend API routes and controllers for Fabman operations with proper error handling

Reviewed Changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
includes/Actions/Fabman/Routes.php	Defines API routes for Fabman authorization and workspace fetching
includes/Actions/Fabman/RecordApiHelper.php	Core API helper class handling all Fabman API operations and data mapping
includes/Actions/Fabman/FabmanController.php	Main controller managing authentication, workspace fetching, and integration execution
frontend-dev/src/components/Flow/New/SelectAction.jsx	Adds Fabman to the list of available integrations
frontend-dev/src/components/AllIntegrations/NewInteg.jsx	Registers Fabman component for new integration flow
frontend-dev/src/components/AllIntegrations/IntegInfo.jsx	Adds Fabman authorization component to integration info
frontend-dev/src/components/AllIntegrations/Fabman/*	Complete frontend implementation including authorization, field mapping, and configuration components
frontend-dev/src/components/AllIntegrations/EditInteg.jsx	Adds Fabman to the edit integration flow

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

includes/Actions/Fabman/FabmanController.php

Copilot · 2025-10-07T06:26:44Z

frontend-dev/src/components/AllIntegrations/Fabman/FabmanCommonFunc.js

+export const isConfigInvalid = (fabmanConf, formField) => {
+  if (!fabmanConf.actionName) return true
+
+  if (['update_member', 'delete_member'].includes(fabmanConf.actionName)) {
+    // isEmailMappingInvalid needs to be passed or imported
+    if (isEmailMappingInvalid(fabmanConf, formField)) return true


The function isEmailMappingInvalid is called but not imported or defined in this file. This will cause a runtime error.

Suggested change

export const isConfigInvalid = (fabmanConf, formField) => {

if (!fabmanConf.actionName) return true

if (['update_member', 'delete_member'].includes(fabmanConf.actionName)) {

// isEmailMappingInvalid needs to be passed or imported

if (isEmailMappingInvalid(fabmanConf, formField)) return true

export const isConfigInvalid = (fabmanConf, formFields, checkValidEmail) => {

if (!fabmanConf.actionName) return true

if (['update_member', 'delete_member'].includes(fabmanConf.actionName)) {

// isEmailMappingInvalid needs to be passed or imported

if (isEmailMappingInvalid(fabmanConf, formFields, checkValidEmail)) return true

RishadAlam · 2025-10-08T04:06:29Z

frontend-dev/src/components/AllIntegrations/Fabman/EditFabman.jsx

+    const hasEmailType = selectedField.type && String(selectedField.type).toLowerCase() === 'email'
+    const looksLikeEmailField =
+      /email/i.test(selectedField.name || '') || /email/i.test(selectedField.label || '')
+    return !(hasEmailType || !selectedField.type || looksLikeEmailField)


use !hasEmailType || selectedField.type || !looksLikeEmailField

RishadAlam · 2025-10-08T04:11:41Z

frontend-dev/src/components/AllIntegrations/Fabman/Fabman.jsx

+      logics: [{ field: '', logic: '', val: '' }, 'or', { field: '', logic: '', val: '' }]
+    },
+    trigger_type: '',
+    pro_integ_v: '2.5.4',


Could you explain this trigger_type & pro_integ_v property and its purpose?

RishadAlam · 2025-10-08T04:14:27Z

frontend-dev/src/components/AllIntegrations/Fabman/Fabman.jsx

+  }
+
+  const nextPage = () => {
+    if (isConfigInvalid()) {


use early return on !isConfigInvalid()

RishadAlam · 2025-10-08T04:17:58Z

frontend-dev/src/components/AllIntegrations/Fabman/FabmanAuthorization.jsx

+import { fabmanAuthentication } from './FabmanCommonFunc'
+import Note from '../../Utilities/Note'
+import tutorialLinks from '../../../Utils/StaticData/tutorialLinks'
+import TutorialLink from '../../Utilities/TutorialLink'


add Fabeman documentation link to TutorialLink file

RishadAlam · 2025-10-08T04:27:15Z

frontend-dev/src/components/AllIntegrations/Fabman/FabmanAuthorization.jsx

+    setStep(2)
+  }, [setStep])
+
+  const handleInput = useCallback(


explain why you using callback here

RishadAlam · 2025-10-08T06:03:06Z

includes/Actions/Fabman/FabmanController.php

+            if ($actionName === 'delete_member' || empty($memberId)) {
+                $email = self::getMappedValue($integrationDetails->field_map, 'emailAddress', $fieldValues);
+                if ($email) {
+                    $memberData = self::fetchMemberByEmailInternal($apiKey, $email);


Rename fetchMemberByEmailInternal function

RishadAlam · 2025-10-08T06:03:57Z

includes/Actions/Fabman/FabmanController.php

+        $apiEndpoint = 'https://fabman.io/api/v1/members?q=' . urlencode($email);
+        $apiResponse = HttpHelper::get($apiEndpoint, null, $header);
+
+        if (is_wp_error($apiResponse) || empty($apiResponse) || isset($apiResponse->error) || !\is_array($apiResponse)) {


Optimize those conditions

RishadAlam · 2025-10-08T06:05:47Z

includes/Actions/Fabman/RecordApiHelper.php

+
+    private $lockVersion;
+
+    public function __construct($apiKey, $workspaceId, $accountId, $integrationID = null, $memberId = null, $lockVersion)


Use required params at first, and the not required are last position

RishadAlam · 2025-10-08T06:09:08Z

includes/Actions/Fabman/RecordApiHelper.php

+            $finalData['memberId'] = $this->memberId;
+        }
+
+        if (!empty($integrationDetails->field_map)) {


Optimize the generated field mappings data conditions

RishadAlam · 2025-10-08T06:10:26Z

includes/Actions/Fabman/RecordApiHelper.php

+            foreach ($integrationDetails->field_map as $fieldMap) {
+                if (!empty($fieldMap->formField) && !empty($fieldMap->fabmanFormField)) {
+                    $finalData[$fieldMap->fabmanFormField] = $fieldMap->formField === 'custom'
+                        ? $fieldMap->customValue


Use the Common::replaceFieldWithValue function for getting custom field variable data

Md-Abed-Hossen added 14 commits September 7, 2025 12:43

feat: fabman actions

c1cdff8

chore: update logo and update functionality

323205f

Merge branch 'main' into feat/fabman-action

cddd55f

chore: update logics

8cbe987

chore: integration name set

4761d43

chore: update functionality

0d56df3

Merge branch 'main' into feat/fabman-action

270b5fd

Merge branch 'main' into feat/fabman-action

9d309a1

chore: update member function

a71c57e

chore: update member button fix

e4b0bfc

Revert "chore: update member button fix"

8d68b43

This reverts commit e4b0bfc.

chore: update

760a9f5

chore: udpate respone

cbec046

chore: update

45a9750

RishadAlam requested changes Sep 24, 2025

View reviewed changes

Md-Abed-Hossen added 3 commits September 24, 2025 13:16

chore: update

9f3728b

chore: formatting

0dbf4e5

Merge branch 'main' into feat/fabman-action

2631a51

RishadAlam requested a review from Copilot October 7, 2025 06:25

Copilot AI reviewed Oct 7, 2025

View reviewed changes

RishadAlam requested changes Oct 8, 2025

View reviewed changes


		private $lockVersion;

		public function __construct($apiKey, $workspaceId, $accountId, $integrationID = null, $memberId = null, $lockVersion)

Uh oh!

Feat/fabman-action #116

Are you sure you want to change the base?

Feat/fabman-action #116

Uh oh!

Conversation

Md-Abed-Hossen commented Sep 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants