Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include reaction file path in output #819

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

jamesgol
Copy link
Contributor

@jamesgol jamesgol commented Sep 1, 2022

Details

After playing around with reactions it took me a few minutes to find the reactions.json. I was looking for it in .sliver/config but it went to .sliver-client.

@jamesgol jamesgol requested a review from a team as a code owner September 1, 2022 16:23
@moloch--
Copy link
Member

moloch-- commented Sep 1, 2022

Yea reactions are a "client-side" feature similar to armory etc. this is probably better than just adding it the docs somewhere too.

@jamesgol
Copy link
Contributor Author

jamesgol commented Sep 1, 2022

Hope I'm not annoying you with all these minor changes. I always find the best way to learn about something is just to dig in, which inevitably finds issues or things that can be improved.

@moloch--
Copy link
Member

moloch-- commented Sep 1, 2022

Not at all, keep 'em coming!

@rkervella rkervella merged commit 336068c into BishopFox:master Sep 1, 2022
@jamesgol jamesgol deleted the reaction_file branch September 20, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants