Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rendering charts accross years causes incorrect sorting #15

Closed
Bios-Marcel opened this issue Jul 21, 2024 · 2 comments
Closed

rendering charts accross years causes incorrect sorting #15

Bios-Marcel opened this issue Jul 21, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Bios-Marcel
Copy link
Owner

Due to the fact that the month values (1-12) are the keys of the X-Axis, we can't differentiate between the different years. So December of previous year will render after november of current year.
@Bios-Marcel Bios-Marcel added the bug Something isn't working label Jul 21, 2024
@Bios-Marcel
Copy link
Owner Author

java_PG4EEvBvbj

Generating data over 10 years, this actually looks horrible. We somehow need to calculate some type of precision and an x-axis value that isn't purely numeric.

Bios-Marcel added a commit that referenced this issue Jul 21, 2024
@Bios-Marcel
Fix rendering of balance chart across years
f7794b1 
Addresses #15
Bios-Marcel added a commit that referenced this issue Jul 21, 2024
@Bios-Marcel
Fix rendering of balance chart across years
77f7028 
Adresses #15
@Bios-Marcel
Copy link
Owner Author

Fixed ~

While I have still seen an issue where the year 2034 for some reason rendered after year 2029, this only occurred once and I don't care FOR NOW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bios-Marcel