Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix num_available_cores in lsf #393

Merged
merged 4 commits into from
Jan 29, 2025
Merged

fix num_available_cores in lsf #393

merged 4 commits into from
Jan 29, 2025

Conversation

michalozeryflato
Copy link
Collaborator

No description provided.

SagiPolaczek
SagiPolaczek previously approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@SagiPolaczek SagiPolaczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We miss printing the answer in the case where verbose is True.
Not a big deal tho.. I don't like it anyway :P

LGTM

@SagiPolaczek
Copy link
Collaborator

Maybe one thing worth mentioning, I think os.env returns a string.

SagiPolaczek
SagiPolaczek approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@SagiPolaczek SagiPolaczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalozeryflato michalozeryflato merged commit 99cb04b into master Jan 29, 2025
6 checks passed
@michalozeryflato michalozeryflato deleted the num_available_cores_lsf branch January 29, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagiPolaczek SagiPolaczek SagiPolaczek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalozeryflato @SagiPolaczek