Fix the problem with using BTK in other libraries (like OpenSim) on Windows with MSVC. #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indows.
Problem -- Including the BTK headers causes an error on Windows with VS2015.
" .... cstdint: 'uint8_t' is not a member of global namespace .... ".
The error appears to be in the standard library but is actually
caused by the fact that Utilities/stdint.h is included for MSVC
builds and the directory Utilities is in the include path for the
compiler. When trying to search for a header named stdint.h, the
compiler keeps running into Utilities/stdint.h even when the
original intention was to find the header in the system standard
path.
Solution -- Rename the file Utilities/stdint.h to something else that does not
conflict with standard library header of the same name therefore
avoiding compiler choosing this header when standard library header
is meant to be found.
Fix RPATH for OSX.
melund
added a commit
to melund/BTKCore
that referenced
this pull request
Dec 3, 2019
…' into integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem -- Including the BTK headers causes an error on Windows with VS2015.
" .... cstdint: 'uint8_t' is not a member of global namespace .... ".
The error appears to be in the standard library but is actually
caused by the fact that Utilities/stdint.h is included for MSVC
builds and the directory Utilities is in the include path for the
compiler. When trying to search for a header named stdint.h, the
compiler keeps running into Utilities/stdint.h even when the
original intention was to find the header in the system standard
path.
Solution -- Rename the file Utilities/stdint.h to something else that does not
conflict with standard library header of the same name therefore
avoiding compiler choosing this header when standard library header
is meant to be found.