Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issues:
autoColor
andwhiteMargin
are alwaysTRUE
and it's caused by the following code invue-qr.js
:autoColor: toBoolean(that.autoColor) || true
whiteMargin: toBoolean(that.whiteMargin) || true
logoCornerRadius
not working with number value0
while it's working when using string value0
due to the code:logoCornerRadius: that.logoCornerRadius || 8
awesome-qr
, thebindElement
is optional. It provides the ability to not bind to any HTML node and only return the dataURI generated for further processing. However,vue-qr
always binds the generated QR image data to a HTML node and it's not so handy in some scenarios.To adress issue 1 and issue 2, I moved the default value for each prop to props definition and added validations for them. And for backward compatibility,
String
value is also allowed forwhiteMargin
,autoColor
andbinarize
.To address issue 3, I added a new prop named
bindElement
which acceptsBoolean
value with default valueTRUE
.Regards,