Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnome/adwaita theme for one dark #654

Merged
merged 5 commits into from
Dec 3, 2021
Merged

Conversation

MalcolmMielle
Copy link
Contributor

@MalcolmMielle MalcolmMielle commented Nov 15, 2021

A theme that fits within gnome/adwaita and a very dark+bright green retro theme.

@Binaryify
Copy link
Owner

thank for the PR, these themes style are different, I suggest delete package.json entry, let user choose those theme in setting menu, also could you merge 2 PR to 1 PR to avoid the conflict?

@MalcolmMielle
Copy link
Contributor Author

Sure. I'm off at the moment I'll come back to it next month!

@Binaryify
Copy link
Owner

Sure. I'm off at the moment I'll come back to it next month!

okay, have a good time~

@MalcolmMielle
Copy link
Contributor Author

This PR now includes both the retro and gnome theme.

I'm also removed the package.json entry and added them as option in the settings. That says the change seems to be inconsistent :S. It works good when I manually change in the settings.json, but when I trigger it in the UI setting menu, the theme is not always applied. However, I cannot see why I would have this behavior :S.

Could you maybe confirm (or not) if you see the same behavior ?

@Binaryify
Copy link
Owner

@MalcolmMielle the themes in the setting menu, need reload the window to apply, because they are created dynamically

@Binaryify
Copy link
Owner

Binaryify commented Dec 3, 2021

it's okay, I will merge and check that, you did a good job

@MalcolmMielle
Copy link
Contributor Author

Thanks! I had the problem after reloading the windows actually :S

@Binaryify Binaryify merged commit 2f5e140 into Binaryify:master Dec 3, 2021
@Binaryify
Copy link
Owner

I will check that~

@Binaryify
Copy link
Owner

Binaryify commented Dec 5, 2021

Setting only support default theme(One Dark Pro).
had you try toggle to the One Dark Pro then select the built-in theme

@jaitra1264
Copy link

I am a newbie, how do I enable the retro theme?? it looks so cool

@Binaryify
Copy link
Owner

@jaitra1264 check the vscode setting

@small-fork
Copy link

Hello @MalcolmMielle I'm brand new to VSCode. I installed "One Dark Pro" but want to use the Gnome option. However, in my VSCode settings, all I'm seeing are these options:
image

There is no Gnome or Retro. Please forgive me if I’m missing something obvious! I'm also very disoriented by GitHub, so I'm likely not understanding how to get the Gnome option to appear. Thank you!

@MalcolmMielle
Copy link
Contributor Author

Hi! If I remember correctly, you have to use the classic one dark pro and the option for retro/gnome is in the settings of the extension. I give it to you that's pretty confusing

@small-fork
Copy link

small-fork commented Dec 28, 2023

@MalcolmMielle Thank you for the reply. I'm not sure if I did this right...I set Workbench to "One Dark Pro" then went into Extensions > One Dark Pro and found Gnome in the "editor" appearance. Before that, the Editor theme dropdown was in the main Appearance settings.

The whole setup is pretty confusing! I don't know if this was right? I'm still not clear on Workbench vs Editor anyway :)

UPDATE: I don't think it actually changed things to look like Gnome in my files. I'm pretty lost at this point :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants