PHP 8 named arguments color

[asolux]

There are a mish mash coloring for the PHP 8 named arguments.

Screenshot:

For reproduction:

<?php

sample('string', param: 1);
figure(sprintf('pattern %d', 1), param: 1);
type(Class::func(), param: 1);
throw new \Exception(sprintf('pattern %d', 1), param: 1);
type(
    Class::func(), 
    param: 1
);
throw new \Exception(
    "Error Processing Request",
    param: 1,
    option: 0
);
Class::func('string', mode: 0);
type(Class::func(), param: 1);

Screenshot of the code above:

Thank you for your great work!

[Binaryify]

is this what you want ?

[asolux]

You forgot the colons. 😀😉
I am not familiar with the color themes. But as far as I have seen the "php 8 named arguments" cannot be identified. The orange colored ones are constants? Am I correct? I personally would like it in gray - or I would change it to gray. However, if they cannot be identified, that is not possible. (?)

[Binaryify]

how about this

[asolux]

Looks good! 🙂 How can I do that?

[Binaryify]

you can add this snippet in your settions.json before I release next version

"editor.tokenColorCustomizations": {
    "[One Dark Pro]": {
      "textMateRules": []
    },
    "textMateRules": [
      {
        "name": "php scope",
        "scope": "entity.name.variable.parameter.php,punctuation.separator.colon.php,constant.other.php",
        "settings": {
          "foreground": "#abb2bf"
        }
      },
    ]
  },

[asolux]

Great! Seems to be working fine. However, I still added the entity.name.goto-label.php key.
If I notice anything else, I'll get in touch again.
Thanks!