Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing highlighting for C++ namespaces #412

Closed
Shatur opened this issue Aug 1, 2020 · 5 comments · Fixed by #415
Closed

Missing highlighting for C++ namespaces #412

Shatur opened this issue Aug 1, 2020 · 5 comments · Fixed by #415

Comments

@Shatur
Copy link

Shatur commented Aug 1, 2020

Thank you for your theme!
Could you highlight namespaces in C++? Usually it highlighted as a class.
изображение

Code from screenshot.
pagdot added a commit to pagdot/OneDark-Pro that referenced this issue Aug 19, 2020
@pagdot
add syntax highlight definition for namespaces
817def7 
 fixes Binaryify#412
@pagdot pagdot mentioned this issue Aug 19, 2020
Merged
Binaryify added a commit that referenced this issue Aug 29, 2020
@Binaryify
Fixed JavaScript operator color error #407, fixed #412
211aec9
@Binaryify
Copy link
Owner

I just release a new version, you can check it later

@Shatur
Copy link
Author

Shatur commented Aug 29, 2020

Sorry, I don't get it. Why you removed namespace highlighting in 211aec9?

@Binaryify
Copy link
Owner

oh, that's a merge error, will fix it now

Binaryify added a commit that referenced this issue Aug 29, 2020
@Binaryify
fixed #412
f6abb7e
@Binaryify
Copy link
Owner

please check v3.8.7

@Shatur
Copy link
Author

Shatur commented Aug 29, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add syntax highlight definition for namespaces pagdot/OneDark-Pro
2 participants
@Binaryify @Shatur