Updated VSCode Warning Colors Do Not Match

[travisbashor]

In VSCode update 1.36.1, a color was chosen for list.warningForeground and editorWarning.foreground - a golden yellow color. Since OneDarkPro does not specify colors for those fields, the same golden yellow shows up by default in the editor, breaking the consistency of the OneDarkPro theme.

See here for the change.

I've been using

"workbench.colorCustomizations": {
        "list.warningForeground": "#c24038",
        "editorWarning.foreground": "#c24038"
    }

to compensate in the short term.

Consider updating the theme to specify colors for those, so that the theme will be consistent regardless of VSCode updates.

[Binaryify]

could you provide a screenshot about what it can change

[travisbashor]

Sure thing. Those are the default colors below. I replaced the yellow with the red above, but I think even that red might be a little too dark. It was just better than the yellow :)

[Binaryify]

just release a new version, you can check it now

[cyberbit]

I'm confused why editorWarning.foreground was changed to (1) red and (2) a red that doesn't even match the rest of the theme:

IMHO the switch to a yellow color for warning squigglies was better for visually grepping a file for linter issues vs. compile issues.

[louis-lau]

I've been confused for the past day why the hell warnings were showing up as errors in vscode. Guess they weren't. I'm still confused by the choice to make warnings dark red and errors a slightly brighter red.

Warnings aren't red in atom either.

[grovertb]

You should think about returning to the yellow warning color, because it is confusing to have the error and warning be red.

[Dreamacro]

I spent a lot of time thinking about why warning is red. please revert this change. BTW I use golint

I consciously decided to display my tslint erros with warning color (yellow in recent VS Code). Now it's all one big mess; first I wanted to blame VS Code, then tslint.... until I realized it's my favorite theme having trouble :( .

Update: To use default VS Code colors (the yellow one), a workaround is to set settings like this:

"workbench.colorCustomizations": {
  "list.warningForeground": "#CCA700",
 "editorWarning.foreground": "#CCA700"
}

[Binaryify]

@cyberbit @louis-lau @grovertb @Dreamacro @Ford04 sorry for that, will change it be yellow, but not the default yellow for more coordinated

[Binaryify]

just release a new version~ thanks for all feedback
also @travisbashor don't be discouraged, the default colors are really incongruous, now this theme become more better than before~