use offset() instead of line()/column() for issue #39#45
Open
felix9 wants to merge 1 commit intoBinaryMuse:masterfrom
Open
use offset() instead of line()/column() for issue #39#45felix9 wants to merge 1 commit intoBinaryMuse:masterfrom
felix9 wants to merge 1 commit intoBinaryMuse:masterfrom
Conversation
Contributor
Author
|
Hi, @BinaryMuse, do you have time to look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
toml.parseabout 2x faster for typical inputs.Computing
line()andcolumn()for every node is expensive, and the information is only needed for error messages.offset()is much cheaper, and it's easy to compute line/column from the offset when we need them.I'm leaving all the uses of line/column in toml.pegjs for now, because removing them will conflict with pr #44 . I'll fix it up after that one is resolved (either yes or no).