Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows side fixes for issue #86 #92

Merged
merged 4 commits into from
Jan 10, 2020

Conversation

russhaun
Copy link

fixed issues that were preventing artillery from starting on windows. reorganized code to take on new features. now is stable enough run. stiil have email issues to deal with been working with @corelanc0d3r to address any thing that might come up.

russhaun added 4 commits June 4, 2019 17:07
updating to current BD release for issue #86
after some updates were applied which are all good by the way. some things needed to be shifted around for windows. UAC script was broken and not being called properly
also email imports were fixed?. still some issues but with changes made windows side works properly now. some changes are going to have to be made when it comes to windows for now i just pass in that function i played with it enough to allow for artillery to start and function. changed default in windows path choice for program files (x86). if i don't wierd issues pop up with older windows clients. put check config functions after it is found out if user is root/admin comes down to permissions issue on windows. also removed rd port from config. altered open_sesame() function to only fire on linux.
@russhaun
Copy link
Author

hey @corelanc0d3r if IsUserAdmin function will only work on windows so it is already in the if is_widows group. hopefully that makes sense?

@corelanc0d3r
Copy link

sure, but if I read the code well, all calls to check_config() are now inside "if is_windows()"?

@russhaun
Copy link
Author

russhaun commented Jan 10, 2020

Hey @corelanc0d3r here is a screen shot of the current artillery.py. as you can see there is a check_config() in the linux block. from the commit data it looks as if it is in windows section but it is not i did add it. it only runs check_config(0 if user is root

issue#86(linux_check_config)

@corelanc0d3r
Copy link

ok, should be good then :)

@russhaun
Copy link
Author

hey @trustedsec .i am working on a new readme that includes updated info pertaining to file structure layout and also included windows values where appropriate. at this time i would also like to update the changelog and credits file to reflect changes since last update. I will wait until this is accepted unless ok'd upstream to apply those changes as well

@trustedsec
Copy link

Sounds good and appreciate the work on this. No issues at all.

@trustedsec trustedsec merged commit d1a3808 into BinaryDefense:master Jan 10, 2020
@russhaun russhaun deleted the win_fixes branch January 10, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants