Skip to content

Comments

Modify small-step reduction to eliminate "stuck" expressions#2

Merged
ivg merged 4 commits intoBinaryAnalysisPlatform:masterfrom
ccasin:smallstep
May 16, 2018
Merged

Modify small-step reduction to eliminate "stuck" expressions#2
ivg merged 4 commits intoBinaryAnalysisPlatform:masterfrom
ccasin:smallstep

Conversation

@ccasin
Copy link
Contributor

@ccasin ccasin commented May 15, 2018

This is achieved by:
a) replacing premises of the form e ~> v with "step" rules that do
incremental evaluation of subexpresions, and
b) reworking variable and let rules to avoid the need to modify the
context while evaluating subexpressions

This is achieved by:
a) replacing premises of the form e ~> v with "step" rules that do
   incremental evaluation of subexpresions, and
b) reworking variable and let rules to avoid the need to modify the
   context while evaluating subexpressions
@ivg ivg self-assigned this May 16, 2018
@ivg ivg self-requested a review May 16, 2018 11:47
Copy link
Member

@ivg ivg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, now it's much better!

Can you please add some wording for the multistep reduce rule? It appears only in the last page but is used in the premises from the very beginning without any ado. And although intuition tells correctly what it does, it is better not to rely on other's intuition :)

bil.ott Outdated
delta |- e ~>* e

delta1 |- e1 ~> e2
delta2 |- e2 ~>* e3
Copy link
Member

@ivg ivg May 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using different deltas here? To my understanding it should be

delta |- e1 ~> e2
delta |- e2 ~>* e3
----------------------- reduce
delta |- e1 ~>* e3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct - sorry for this error (it's a hold-over from the previous iteration that had the expression reduction relation modify the environment).

I'll fix this and add a sentence or two explaining the ~>* relation to the latex file.

Copy link
Member

@ivg ivg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small typo, perhaps

bil.tex Outdated
\end{description}

This section also defines $\Delta \vdash e_1 \leadsto^{*} e_2$. This relation
is the reflexive, transitive closure of $\leadsto$ and use useful to describe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/use/is?

@ivg ivg merged commit 06ad225 into BinaryAnalysisPlatform:master May 16, 2018
@ccasin ccasin deleted the smallstep branch May 17, 2018 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants