Skip to content

Conversation

DIJamner
Copy link
Contributor

Fixes issues #846 and #843 by using the right comparison and adding a necessary case to a simplified type inference function.

Copy link
Member

@ivg ivg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm requesting a review from @gitoleg, since he has nearly the same fixes on his wip branch, so he might have some additional insights

@ivg ivg requested a review from gitoleg June 27, 2018 13:06
@ivg
Copy link
Member

ivg commented Jun 27, 2018

@gitoleg, please review and merge when ready.

Copy link
Contributor

@gitoleg gitoleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@gitoleg gitoleg merged commit c23f0a6 into BinaryAnalysisPlatform:master Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants