Adding support for CDQ, CDQE, CQO, CWD, CWDE, CBW opcodes #833
Conversation
|
Thanks! Assigning @gitoleg as he is currently on the lifters stuff. Oleg, can you also check if we need to enable any checks in the veri suite, that will cover the new functionality? |
There was a problem hiding this comment.
Everything is correct, as far as I see.
Can you just re-indent your code, please?
@ivg Speaking about veri suite. the 0x98 (at least cdqe) is already there. So we can try to find a few 0x99 cases in order to extend our suite, although I believe that it's not a very frequent opcode
|
@gitoleg : just ran ocp-indent on them. let me know if you have a specific config you'd like me to use. re: opcodes: I actually had to add the instruction because of 0x99 opcodes (they seem to be common in some of the binaries I'm looking at) |
|
@ethan42 so my faith that they are seldom was wrong : ) |
No description provided.